[#JDO-32] Some tests, when they fail, do not close pmf

JDO

Some tests, when they fail, do not close pmf

Created: 30/Apr/05 02:38 AM Updated: 23/Apr/06 02:11 AM

Return to search

Component/s:

tck2

Affects Version/s:

None

Fix Version/s:

JDO 2 beta

Time Tracking:

Not Specified

Resolution Date:

23/Apr/06 02:11 AM

Description

« Hide

Classes in the api.persistencemanager package and subpackages, when the test FAILS, or in some cases when there is an ERROR, pmf is not closed. This is responsible for about 200MB of unrecovered memory usage, causing java.lang.OutOfMemoryError before a work-around was checked in. See ~~JDO-21~~.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#168430	Thu May 05 21:44:58 UTC 2005	mbo	~~JDO-32~~ Some tests, when they fail, do not close pmf. Change method closePMF to make sure that the pmf is closed and changed cleanup method in PersistenceManagerTest
				Files Changed
				MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/persistencemanager/PersistenceManagerTest.java MODIFY /incubator/jdo/trunk/ri11/test/java/org/apache/jdo/test/util/AbstractTest.java MODIFY /incubator/jdo/trunk/tck11/test/java/org/apache/jdo/tck/api/persistencemanager/PersistenceManagerTest.java MODIFY /incubator/jdo/trunk/tck11/test/java/org/apache/jdo/tck/JDO_Test.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/JDO_Test.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 06/May/05 06:49 AM

I changed method closePMF in the tck test superclass JDO_Test. If method closing the PersistenceManagerFactory fails, it checkes for open PersistenceManagers, closes them and closes the PMF again. I did a similar change in the test superclass of the ri11 test cases.

Another change is in the superclass of the PersistenceManager test. It implements a cleanup method that is called before the PMF is closed. In the old implementation any cleanup failure bypasses the code that closes the pmf. I changed this such that the pmf is closed in any case.

Michael Bouschen made changes - 06/May/05 06:49 AM

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Michael Bouschen made changes - 06/May/05 06:50 AM

Assignee

Michael Bouschen [ mbo ]

Michelle Caisse made changes - 01/Nov/05 06:54 AM

Status

Resolved [ 5 ]

Closed [ 6 ]

[ Permlink | « Hide ]

Michael Bouschen added a comment - 23/Apr/06 02:08 AM

Reopened to set the Fix Version/s field to JDO 2 beta.

Michael Bouschen made changes - 23/Apr/06 02:08 AM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

Michael Bouschen made changes - 23/Apr/06 02:11 AM

Resolution		Fixed [ 1 ]
Fix Version/s		JDO 2 beta [ 12310683 ]
Status	Reopened [ 4 ]	Closed [ 6 ]