TestHashSetCollections, TestSetCollections : schema incorrect

• Key: JDO-261
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Michelle Caisse
• Reporter: Andy Jefferson
• Component/s: tck2

Description

HashSetCollections/SetCollections are mapped incorrectly. They should have a primary-key specified in the metadata to tell the JDO implementation which columns to use for PK. Without this the JDO implementation can do whatever it likes wrt defining a PK. This includes adding its own adapter columns.

Comments

[Michelle Caisse]

I fixed the orm metadata for datastore identity with revision 357130, but the error persists. The error also occurs with application identity, which does not require the primary-key specification in the mapping.

test(org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections)javax.jdo.JDODataStoreException: Add request failed : INSERT INTO applicationidentity0.HASHSET_OF_OBJECT2 (IDENTIFIER,COLLVAL,ADPT_PK_IDX) VALUES (?,?,?)

FailedObject:[Ljava.lang.Object;@102720c

at org.jpox.store.rdbms.scostore.NormalSetStore.addAll(NormalSetStore.java:657)

at org.jpox.store.mapping.CollectionMapping.postUpdate(CollectionMapping.java:282)

at org.jpox.store.rdbms.request.UpdateRequest.execute(UpdateRequest.java:282)

at org.jpox.store.rdbms.table.ClassTable.update(ClassTable.java:2118)

at org.jpox.store.StoreManager.update(StoreManager.java:780)

at org.jpox.state.StateManagerImpl.flush(StateManagerImpl.java:4401)

at org.jpox.state.StateManagerImpl.runReachability(StateManagerImpl.java:3154)

at org.jpox.AbstractPersistenceManager.preCommit(AbstractPersistenceManager.java:3145)

at org.jpox.NonmanagedTransaction.commit(NonmanagedTransaction.java:435)

at org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections.runTest(TestHashSetCollections.java:96)

at org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections.test(TestHashSetCollections.java:75)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:204)

at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)

at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)

[Andy Jefferson]

Well if you look at the message received
Add request failed : INSERT INTO datastoreidentity0.HASHSET_OF_OBJECT2 (IDENTIFIER,COLLVAL,ADPT_PK_IDX) VALUES (?,?,?)
you have a field that has a serialised element. You have an ORM definition of
<field name="HashSetOfObject2" table="HASHSET_OF_OBJECT2">
    <join column="IDENTIFIER"/>
    <element column="COLLVAL"/>
</field>

So in the join table we have a FK back to the owner, a value column, and we need to impose a PK (since I have no spec that defines how to specify that no PK is required).
I don't see any primary-key specification, so how does JPOX know what is the PK of this join table ?

[Michelle Caisse]

Fixed with revision 357291. As the serialized elements cannot take a primary key, I removed this mapping. I changed all fields with serialized elements so that the field itself is serialized and no join table is used.