[#JDO-257] Change return type of makePersistent from void to Object

JDO

Change return type of makePersistent from void to Object

Created: 10/Dec/05 04:37 AM Updated: 11/Jan/06 10:02 AM

Return to search

Component/s:

api2

Affects Version/s:

None

Fix Version/s:

JDO 2 beta

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
attachcopy.patch	2006-01-11 04:42 AM	Craig Russell	3 kB
attachInterfaces.patch	2006-01-02 03:51 AM	Michael Bouschen	3 kB
persistencemanager.patch	2005-12-10 04:38 AM	Craig Russell	5 kB

Resolution Date:

11/Jan/06 10:02 AM

Description

« Hide

The signatures of makePersistent and makePersistentAll are changed to return the persistent instances. This change was adopted by the expert group 8-Dec-2005.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#355585	Fri Dec 09 19:53:43 UTC 2005	clr	~~JDO-257~~ Changed signatures of makePersistent to return Object
				Files Changed
				MODIFY /incubator/jdo/trunk/api20/src/java/javax/jdo/PersistenceManager.java

Repository	Revision	Date	User	Message
ASF	#355651	Fri Dec 09 23:39:32 UTC 2005	clr	~~JDO-257~~ Adapt runtime20 to the change in makePersistent return types
				Files Changed
				MODIFY /incubator/jdo/trunk/runtime20/src/java/org/apache/jdo/impl/pm/PersistenceManagerImpl.java MODIFY /incubator/jdo/trunk/runtime20/src/java/org/apache/jdo/impl/pm/PersistenceManagerWrapper.java MODIFY /incubator/jdo/trunk/runtime20/src/java/org/apache/jdo/impl/pm/CacheManagerImpl.java

[ Permlink | « Hide ]

Craig Russell added a comment - 10/Dec/05 04:38 AM

This patch implements the change to the makePersistent apis.

Craig Russell made changes - 10/Dec/05 04:38 AM

Field	Original Value	New Value
Attachment		persistencemanager.patch [ 12321240 ]

[ Permlink | « Hide ]

Craig Russell added a comment - 10/Dec/05 04:41 AM

The javadoc for these methods is weak. Someone needs to add more information regarding the return values and the fact that detached instances are not returned but values are merged from the detached instance to the persistent instances.

[ Permlink | « Hide ]

Craig Russell added a comment - 18/Dec/05 02:59 AM

The methods attachCopy and attachCopyAll should be removed as part of this change. This will require corresponding changes to the runtime20 and tck20 projects as well.

Repository	Revision	Date	User	Message
ASF	#359422	Wed Dec 28 06:51:18 UTC 2005	clr	~~JDO-257~~ removed attachCopy and attachCopyAll methods; left comments to be removed later
				Files Changed
				MODIFY /db/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/instancecallbacks/InstanceLifecycleListenerAttach.java MODIFY /db/jdo/trunk/api20/src/java/javax/jdo/PersistenceManager.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 02/Jan/06 03:51 AM

Attached you find a patch (attachInterfaces.patch) for review. It removes javadoc references to PM.attachCopy which has been removed.

Michael Bouschen made changes - 02/Jan/06 03:51 AM

Attachment

attachInterfaces.patch [ 12321627 ]

Repository	Revision	Date	User	Message
ASF	#365353	Mon Jan 02 14:56:43 UTC 2006	mbo	~~JDO-257~~ remove javadoc references to PM.attachCopy
				Files Changed
				MODIFY /db/jdo/trunk/api20/src/java/javax/jdo/listener/AttachCallback.java MODIFY /db/jdo/trunk/api20/src/java/javax/jdo/listener/AttachLifecycleListener.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 02/Jan/06 11:58 PM

Checked in the patch (modified according to Craig's comment); see revision 365353.

Repository	Revision	Date	User	Message
ASF	#367855	Wed Jan 11 01:02:01 UTC 2006	clr	~~JDO-257~~ final update to remove attachCopy from PersistenceManager
				Files Changed
				MODIFY /db/jdo/trunk/api20/src/java/javax/jdo/PersistenceManager.java

[ Permlink | « Hide ]

Craig Russell added a comment - 11/Jan/06 04:42 AM

Please review.
This is the final patch for this issue. Removes all references (including javadoc and comments) to attachCopy API.

Craig Russell made changes - 11/Jan/06 04:42 AM

Attachment

attachcopy.patch [ 12321851 ]

[ Permlink | « Hide ]

Michael Bouschen added a comment - 11/Jan/06 07:32 AM

The patch attachCopy.patch looks good.

[ Permlink | « Hide ]

Craig Russell added a comment - 11/Jan/06 10:02 AM

Committed revision 367855.

Craig Russell made changes - 11/Jan/06 10:02 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]