[#JDO-230] Fix order of makePersistent() and addTearDownClass() in localSetUp methods

JDO

Fix order of makePersistent() and addTearDownClass() in localSetUp methods

Created: 08/Dec/05 01:11 AM Updated: 09/Dec/05 10:07 PM

Component/s:

tck2

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-230.patch	2005-12-09 01:16 AM	Michael Watzek	77 kB

Resolution Date:

09/Dec/05 10:07 PM

Description

« Hide

The order of calls makePersistent() and addTearDownClass() in localSetUp methods is significant: addTearDownClass() must be called before makePersistent(). This ensures that the next test run will cleanup the database.

Currently, many tests call makePersistent() before addTearDownClass(). Given that there is data in the database that will cause a duplicate key exception, the database will not be cleaned up, because tear down classes have not been added at the time the exception is thrown.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Craig Russell added a comment - 08/Dec/05 07:59 AM

JDO 2 beta has not shipped yet; so this bug should not affect it.

Craig Russell made changes - 08/Dec/05 07:59 AM

Field	Original Value	New Value
Affects Version/s	JDO 2 beta [ 12310683 ]

[ Permlink | « Hide ]

Michael Watzek added a comment - 09/Dec/05 01:16 AM

The attched patch fixes this issue.

Michael Watzek made changes - 09/Dec/05 01:16 AM

Attachment

JDO-230.patch [ 12321227 ]

Repository	Revision	Date	User	Message
ASF	#355479	Fri Dec 09 13:03:42 UTC 2005	brazil	~~JDO-230~~: Fix order of makePersistent() and addTearDownClass() in localSetUp methods.
				Files Changed
				MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/PromotionOfNumericOperands.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/UnconstrainedVariable.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/sql/AllowedAPIMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryFromExistingQueryBoundToPMFromSameVendor.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithCandidateClass.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/sql/NoCandidateClass.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/persistencemanagerfactory/AbstractGetPMF.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetCandidateCollection.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/MixedVariables.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/IgnoreCacheFalse.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithCandidateClassAndFilter.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/delete/DeleteQueryElements.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/Grouping.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/persistencecapable/AbstractPersistenceCapableTest.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedStringMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/sql/ShapeOfResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/Division.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/ExecutingMultipleQueriesSimultaneouslyIsThreadSafe.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/DefaultResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/LogicalComplement.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/AggregateResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/sql/NewQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/ExecuteQueryWithArray.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/ShapeOfResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithCandidateClassAndExtent.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedCollectionMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/EqualityAndComparisonsBetweenDateFieldsAndParameters.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/StartsWithAndEndsWith.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/BinaryAddition.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/mapping/CompletenessTest.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedJDOHelperMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetOrdering.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/parameters/ParameterDeclaredWithSameNameAsFieldOfCandidateClass.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/EqualityAndComparisonsBetweenPrimitivesAndWrapperInstances.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/ResultClassRequirements.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/SeparateNamespaceForTypeNames.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithCandidateClassAndCollection.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NullCollectionsAndIsEmpty.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/BooleanLogicalAND.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/SignInversion.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/UnmodifiableQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/VariablesAndFields.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/ParenthesesMarkOperatorPrecedence.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithExtent.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/persistencemanager/cache/EvictingWithRestoreValuesFalse.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/VariableInResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/CompileQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/parameters/OrderOfParameters.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/WhiteSpaceIsACharacterAndIgnored.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/ExecuteQueryWithMap.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/BooleanLogicalOR.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/GetFetchPlan.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedMapMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryFromRestoredSerializedQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/parameters/ParameterBoundToDifferentPM.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/PositiveRange.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/ChangeQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/Unique.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/persistencemanager/cache/EvictingWithRetainValuesFalse.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/Close.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/NullResults.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithExtentAndFilter.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/MetadataSearchOrder.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/delete/DeletePersistentAll.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/RangeAsString.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/EqualityAndComparisonsBetweenStringFieldsAndParameters.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/DeclareImports.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/keywords/SingleString.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/DeclareParameters.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetUnique.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedMathMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/DenoteUniquenessInFilter.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/ComparingPersistentAndNonPersistentInstance.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewNamedQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SingleStringQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/VariablesWithoutExtent.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetRange.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/QueryResultPassedToAnotherQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/ConditionalAND.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/parameters/ImplicitParameters.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/ResultExpressions.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NavigationThroughANullValuedField.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetGrouping.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/OrderingSpecification.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/MultipleIdenticalImports.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/NPEInResultExpr.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NullCollectionsAndContainsMethod.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/Multiplication.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/StringConcatenation.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/CharacterAndStringLiterals.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/QueryExtentions.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/DefaultUnique.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/keywords/UseOfThisToAcessHiddenField.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/MultipleActiveQueryInstanceInSamePersistenceManager.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/ComparingCollectionFieldToNull.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/DistinctQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/IdentifiersEqualFieldNames.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NamespaceOfIdentifiers.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQuerySingleString.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/Modulo.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/api/persistencemanager/cache/EvictingCollectionOfInstancesSideEffects.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetterReplacePreviousValues.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/BitwiseComplement.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/Having.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithSpecifiedLanguageAndQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/ImmutableQueryResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/NewQueryWithCandidateClassCollectionFilter.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetResultClass.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/BinarySubtraction.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/QueryIsSerializable.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/Instanceof.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/lifecycle/StateTransitions.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/parameters/PrimitiveParameterPassedAsNull.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/ExecuteQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NavigationThroughACollectionField.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NavigationThroughReferencesUsesDotOperator.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/UnaryPlus.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/ConditionalOR.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetResult.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/NegativeRange.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/result/DistinctCandidateInstances.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/QueryWithNoFilter.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/keywords/ThisIsReservedWordForElementOfCollection.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetCandidateExtent.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SetFilter.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/Cast.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/CloseAll.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 09/Dec/05 07:43 PM

The patch looks good, no comments.

[ Permlink | « Hide ]

Michael Watzek added a comment - 09/Dec/05 10:07 PM

The attched patch has been checked in (revision 355479).

Michael Watzek made changes - 09/Dec/05 10:07 PM

Resolution		Fixed [ 1 ]
Fix Version/s	JDO 2 beta [ 12310683 ]
Status	Open [ 1 ]	Resolved [ 5 ]