[#JDO-217] The expected result in JDO2 query test cases should have the exact runtime type of the query.

JDO

The expected result in JDO2 query test cases should have the exact runtime type of the query.

Created: 17/Nov/05 11:24 PM Updated: 30/Nov/05 07:54 PM

Return to search

Component/s:

tck2

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-217.patch	2005-11-30 01:46 AM	Michael Watzek	32 kB

Resolution Date:

30/Nov/05 07:54 PM

Description

« Hide

This issue depends on ~~JDO-216~~.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael Watzek added a comment - 18/Nov/05 12:23 AM

Please find the list of test classes to be adapted below.

Note:
Test classes in package query.api are adapted by ~~JDO-216~~.
Test classes in package query.result are adapted as part of ~~JDO-164~~.
Remaining test classes (~~JDO-165~~, JDO166) will be implemented according to ~~JDO-216~~.

org.apache.jdo.tck.query.jdoql.keywords.InvalidUseOfKeywords
org.apache.jdo.tck.query.jdoql.keywords.KeywordsAsFieldNames
org.apache.jdo.tck.query.jdoql.keywords.SingleString
org.apache.jdo.tck.query.jdoql.keywords.UppercaseLowercase
org.apache.jdo.tck.query.jdoql.operators.Instanceof
org.apache.jdo.tck.query.jdoql.operators.Modulo
org.apache.jdo.tck.query.jdoql.methods.SupportedMapMethods
org.apache.jdo.tck.query.jdoql.methods.SupportedMathMethods
org.apache.jdo.tck.query.jdoql.methods.SupportedStringMethods
org.apache.jdo.tck.query.jdoql.methods.SupportedJDOHelperMethods
org.apache.jdo.tck.query.jdoql.parameters.ImplicitParameters
org.apache.jdo.tck.query.jdoql.parameters.MixedParameters
org.apache.jdo.tck.query.jdoql.parameters.OrderOfParameters
org.apache.jdo.tck.query.jdoql.variables.VariablesAndFields
org.apache.jdo.tck.query.jdoql.variables.MixedVariables
org.apache.jdo.tck.query.jdoql.variables.UnconstrainedVariable
org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
org.apache.jdo.tck.query.jdoql.RangeAsString
org.apache.jdo.tck.query.jdoql.PositiveRange
org.apache.jdo.tck.query.jdoql.NegativeRange
org.apache.jdo.tck.query.jdoql.IdentifiersEqualFieldNames
org.apache.jdo.tck.query.jdoql.CharacterAndStringLiterals

[ Permlink | « Hide ]

Michael Watzek added a comment - 30/Nov/05 01:46 AM

The attached patch fixes this issue.

The list of affected classes in this patch is different compared to the list above because some classes have already been adapted as part of other patches. Some classes did not need to be adapted at all because they do not specify expected query results.

This is the list of affected files:

M test\java\org\apache\jdo\tck\query\QueryTest.java
M test\java\org\apache\jdo\tck\query\api\SingleStringQuery.java
M test\java\org\apache\jdo\tck\query\jdoql\CharacterAndStringLiterals.java
M test\java\org\apache\jdo\tck\query\jdoql\PositiveRange.java
M test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedStringMethods.java
M test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedMathMethods.java
M test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedJDOHelperMethods.java
M test\java\org\apache\jdo\tck\query\jdoql\parameters\OrderOfParameters.java
M test\java\org\apache\jdo\tck\query\jdoql\keywords\SingleString.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\MixedVariables.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\UnconstrainedVariable.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\VariablesAndFields.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\VariablesWithoutExtent.java
M test\java\org\apache\jdo\tck\query\jdoql\operators\Modulo.java
M test\java\org\apache\jdo\tck\query\jdoql\operators\Instanceof.java
M test\java\org\apache\jdo\tck\query\jdoql\RangeAsString.java
M test\java\org\apache\jdo\tck\query\jdoql\IdentifiersEqualFieldNames.java

Michael Watzek made changes - 30/Nov/05 01:46 AM

Field	Original Value	New Value
Attachment		JDO-217.patch [ 12321028 ]

Repository	Revision	Date	User	Message
ASF	#349919	Wed Nov 30 10:53:33 UTC 2005	brazil	~~JDO-217~~: The expected result in JDO2 query test cases should have the exact runtime type of the query.
				Files Changed
				MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/UnconstrainedVariable.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/RangeAsString.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedJDOHelperMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/keywords/SingleString.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedMathMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/IdentifiersEqualFieldNames.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/Modulo.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/QueryTest.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/api/SingleStringQuery.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/MixedVariables.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/VariablesWithoutExtent.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/variables/VariablesAndFields.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/methods/SupportedStringMethods.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/operators/Instanceof.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/parameters/OrderOfParameters.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/CharacterAndStringLiterals.java MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/query/jdoql/PositiveRange.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 30/Nov/05 07:47 PM

Looks good!

[ Permlink | « Hide ]

Michael Watzek added a comment - 30/Nov/05 07:54 PM

The attached patch has been checked in (Revision 349919).

Michael Watzek made changes - 30/Nov/05 07:54 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]