The expected result in JDO2 query test cases should have the exact runtime type of the query.

• Key: JDO-217
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Michael Watzek
• Reporter: Michael Watzek
• Component/s: tck2

Description

This issue depends on JDO-216.

Comments

Please find the list of test classes to be adapted below.

Note:
Test classes in package query.api are adapted by JDO-216.
Test classes in package query.result are adapted as part of JDO-164.
Remaining test classes (JDO-165, JDO166) will be implemented according to JDO-216.

org.apache.jdo.tck.query.jdoql.keywords.InvalidUseOfKeywords
org.apache.jdo.tck.query.jdoql.keywords.KeywordsAsFieldNames
org.apache.jdo.tck.query.jdoql.keywords.SingleString
org.apache.jdo.tck.query.jdoql.keywords.UppercaseLowercase
org.apache.jdo.tck.query.jdoql.operators.Instanceof
org.apache.jdo.tck.query.jdoql.operators.Modulo
org.apache.jdo.tck.query.jdoql.methods.SupportedMapMethods
org.apache.jdo.tck.query.jdoql.methods.SupportedMathMethods
org.apache.jdo.tck.query.jdoql.methods.SupportedStringMethods
org.apache.jdo.tck.query.jdoql.methods.SupportedJDOHelperMethods
org.apache.jdo.tck.query.jdoql.parameters.ImplicitParameters
org.apache.jdo.tck.query.jdoql.parameters.MixedParameters
org.apache.jdo.tck.query.jdoql.parameters.OrderOfParameters
org.apache.jdo.tck.query.jdoql.variables.VariablesAndFields
org.apache.jdo.tck.query.jdoql.variables.MixedVariables
org.apache.jdo.tck.query.jdoql.variables.UnconstrainedVariable
org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
org.apache.jdo.tck.query.jdoql.RangeAsString
org.apache.jdo.tck.query.jdoql.PositiveRange
org.apache.jdo.tck.query.jdoql.NegativeRange
org.apache.jdo.tck.query.jdoql.IdentifiersEqualFieldNames
org.apache.jdo.tck.query.jdoql.CharacterAndStringLiterals

[Michael Watzek]

The attached patch fixes this issue.

The list of affected classes in this patch is different compared to the list above because some classes have already been adapted as part of other patches. Some classes did not need to be adapted at all because they do not specify expected query results.

This is the list of affected files:

M test\java\org\apache\jdo\tck\query\QueryTest.java
M test\java\org\apache\jdo\tck\query\api\SingleStringQuery.java
M test\java\org\apache\jdo\tck\query\jdoql\CharacterAndStringLiterals.java
M test\java\org\apache\jdo\tck\query\jdoql\PositiveRange.java
M test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedStringMethods.java
M test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedMathMethods.java
M test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedJDOHelperMethods.java
M test\java\org\apache\jdo\tck\query\jdoql\parameters\OrderOfParameters.java
M test\java\org\apache\jdo\tck\query\jdoql\keywords\SingleString.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\MixedVariables.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\UnconstrainedVariable.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\VariablesAndFields.java
M test\java\org\apache\jdo\tck\query\jdoql\variables\VariablesWithoutExtent.java
M test\java\org\apache\jdo\tck\query\jdoql\operators\Modulo.java
M test\java\org\apache\jdo\tck\query\jdoql\operators\Instanceof.java
M test\java\org\apache\jdo\tck\query\jdoql\RangeAsString.java
M test\java\org\apache\jdo\tck\query\jdoql\IdentifiersEqualFieldNames.java

[Michael Bouschen]

Looks good!

[Michael Watzek]

The attached patch has been checked in (Revision 349919).