Remove <order> from mapping for HashSetCollections and SetCollections.

• Key: JDO-215
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Michelle Caisse
• Reporter: Craig Russell
• Component/s: tck2

Description

The mapping for HashSetCollections and SetCollections incorrectly have <order> columns.

There should not be an ordering specified for the join table since duplicates are not allowed. The mapping for application identity should not need a primary key, since the JDO implementation should be able to figure out that the primary key is part of the Map.key, but the datastore identity mapping does need a primary key (and again, I'd use the id field of SimpleClass as the join table key column.

Comments

[Michelle Caisse]

The attached patch removes the ALLOW_DUPLICATES order column from the orm metadata and schema for HashSetCollections and Set Collections for both application and datastore identity. It also adds a primary-key="true" attribute to the id column of join tables for SimpleClass in the orm metadata.

The two tests fail with the patch applied. Both application and datastore identity fail, but on different columns.

    [java] test(org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections)javax.jdo.JDODataStoreException: Add request failed : INSERT INTO datastoreidentity0.HASHSET_OF_OBJECT1 (IDENTIFIER,ID,INTVAL,STRINGVAL,ADPT_PK_IDX) VALUES (?,?,?,?,?)
    [java] FailedObject:[Ljava.lang.Object;@1e22c75
    [java] at org.jpox.store.rdbms.scostore.NormalSetStore.addAll(NormalSetStore.java:657)
    [java] at org.jpox.store.mapping.CollectionMapping.postUpdate(CollectionMapping.java:281)
    [java] at org.jpox.store.rdbms.request.UpdateRequest.execute(UpdateRequest.java:282)
    [java] at org.jpox.store.rdbms.table.ClassTable.update(ClassTable.java:1931)
    [java] at org.jpox.store.StoreManager.update(StoreManager.java:780)
    [java] at org.jpox.state.StateManagerImpl.flush(StateManagerImpl.java:4336)
    [java] at org.jpox.state.StateManagerImpl.runReachability(StateManagerImpl.java:3099)
    [java] at org.jpox.AbstractPersistenceManager.preCommit(AbstractPersistenceManager.java:3110)
    [java] at org.jpox.NonmanagedTransaction.commit(NonmanagedTransaction.java:420)
    [java] at org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections.runTest(TestHashSetCollections.java:96)
    [java] at org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections.test(TestHashSetCollections.java:75)
    [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    [java] at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:204)
    [java] at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
    [java] at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)

    [java] test(org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections)javax.jdo.JDODataStoreException: Add request failed : INSERT INTO applicationidentity0.HASHSET_OF_OBJECT2 (IDENTIFIER,COLLVAL,ADPT_PK_IDX) VALUES (?,?,?)
    [java] FailedObject:[Ljava.lang.Object;@56182f
    [java] at org.jpox.store.rdbms.scostore.NormalSetStore.addAll(NormalSetStore.java:657)
    [java] at org.jpox.store.mapping.CollectionMapping.postUpdate(CollectionMapping.java:281)
    [java] at org.jpox.store.rdbms.request.UpdateRequest.execute(UpdateRequest.java:282)
    [java] at org.jpox.store.rdbms.table.ClassTable.update(ClassTable.java:1931)
    [java] at org.jpox.store.StoreManager.update(StoreManager.java:780)
    [java] at org.jpox.state.StateManagerImpl.flush(StateManagerImpl.java:4336)
    [java] at org.jpox.state.StateManagerImpl.runReachability(StateManagerImpl.java:3099)
    [java] at org.jpox.AbstractPersistenceManager.preCommit(AbstractPersistenceManager.java:3110)
    [java] at org.jpox.NonmanagedTransaction.commit(NonmanagedTransaction.java:420)
    [java] at org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections.runTest(TestHashSetCollections.java:96)
    [java] at org.apache.jdo.tck.models.fieldtypes.TestHashSetCollections.test(TestHashSetCollections.java:75)
    [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    [java] at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:204)
    [java] at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
    [java] at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)

[Craig Russell]

The patch seems right. What the JDO implementation has to do is to recognize that the primary key (if needed) for the join table must be a composite key consisting of the key referencing the owning table and id column from the mapped key. For example,

 CREATE TABLE SET_OF_OBJECT0
 (
     IDENTIFIER INTEGER REFERENCES SET_COLLECTIONS NOT NULL,
     OBJREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL
 );

The primary key for this table (if it is needed by the implementation -- let's discuss this) would be IDENTIFIER plus OBJREF.

 CREATE TABLE SET_OF_OBJECT1
 (
     IDENTIFIER INTEGER REFERENCES SET_COLLECTIONS NOT NULL,
     ID BIGINT NOT NULL,
     INTVAL INTEGER NOT NULL,
     STRINGVAL VARCHAR(128) NOT NULL
);

The primary key for this table would be IDENTIFIER plus ID.

[Craig Russell]

This appears to be a JPOX issue assuming an column that doesn't exist.

[Michelle Caisse]

Committed patch with revision 345614

[Andy Jefferson]

 I see that the MetaData is now, for example
<field name="HashSetOfObject1" table="HASHSET_OF_OBJECT1">
    <join column="IDENTIFIER"/>
    <element>
      <embedded>
        <field name="id" primary-key="true" column="ID"/>
        <field name="intField" column="INTVAL"/>
        <field name="stringField" column="STRINGVAL"/>
      </embedded>
    </element>
</field>


That certainly doesnt agree with my definition of a PK specification for the join table. It should be (IMHO) like this

    <join>
        <primary-key>
            <column name="IDENTIFIER"/>
            <column name="ID"/>
        </primary-key>
    </join>
which nicely defines the colums to be used for the join table. Using fields of an embedded object and specifying primary-key there is not logical to me, and not supported by JPOX either. The JPOX online docs
http://www.jpox.org/docs/1_1/constraints.html
provides what we support for PK definition, which is that above.

[Craig Russell]

This is the same issue as JDO-211. So I agree that the metadata should look like:

<field name="HashSetOfObject1" table="HASHSET_OF_OBJECT1">
    <join column="IDENTIFIER">
        <primary-key>
            <column name="IDENTIFIER"/>
            <column name="ID"/>
        </primary-key>
    </join>
    <element>
      <embedded>
        <field name="id" column="ID"/>
        <field name="intField" column="INTVAL"/>
        <field name="stringField" column="STRINGVAL"/>
      </embedded>
    </element>
</field>

[Craig Russell]

As discussed on the JDO expert group, the primary-key annotation is only needed for cases where there is an embedded Map key or Set element that doesn't have a unique key field already known. That is, for embedded SimpleClass with datastore identity used as Map keys or Set elements. The other cases have a known unique field that can be used to make the rows unique. For embedded SimpleClass with appication identity, it's the id field. For non-embedded SimpleClass, it's the foreign key reference.

[Michelle Caisse]

I believe this is now a dup of JDO-211, thus resolved by revision 351537.