Issue Details (XML | Word | Printable)

Key: JDO-202
Type: Test Test
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Michael Bouschen
Reporter: Michelle Caisse
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
JDO

orm.xsd and unit tests for xsd are missing

Created: 05/Nov/05 06:18 AM   Updated: 25/Feb/06 07:48 AM
Return to search
Component/s: api2
Affects Version/s: JDO 2 beta
Fix Version/s: JDO 2 final

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works schematest.patch 2006-01-07 11:00 AM Craig Russell 4 kB
Text File Licensed for inclusion in ASF works schemaValidation-060212.patch 2006-02-13 07:41 AM Michael Bouschen 16 kB
Text File Licensed for inclusion in ASF works schemaValidation-060218.patch 2006-02-19 06:02 AM Michael Bouschen 63 kB
Text File Licensed for inclusion in ASF works schemaValidation-060220.patch 2006-02-21 07:45 AM Michael Bouschen 62 kB
Text File Licensed for inclusion in ASF works XSD.patch 2006-02-12 02:38 PM Craig Russell 1 kB

Resolution Date: 25/Feb/06 07:48 AM


 Description  « Hide
The xsd is missing from api20/src/dtd/javax/jdo and there is no test for it. Also need a test for jdo.xsd.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #357371 Sat Dec 17 19:34:43 UTC 2005 clr JDO-202 Added orm.xsd but a test is still needed
Files Changed
ADD /incubator/jdo/trunk/api20/src/dtd/javax/jdo/orm.xsd

Craig Russell added a comment - 18/Dec/05 05:17 AM
This change adds orm.xsd to the jdo implementation, but it has not been tested.

Committed revision 357371.

Craig Russell added a comment - 18/Dec/05 07:12 AM
This change adds orm.xsd to the jdo implementation, but it has not been tested.

Committed revision 357371.

Craig Russell added a comment - 07/Jan/06 10:00 AM
This issue has two parts. The first part is a program that validates xml files according to schema or DTD that is passed in. The program should look for files that have the suffixes .jdo, .orm, and .jdoquery and validate them against both the DTD and schema.

For example, javax.jdo.schema.SchemaTest is the JUnit test that looks for files with the pattern "positiveXXX.jdo, positiveXXX.orm, positiveXXX.jdoquery, negativeXXX.jdo, negativeXXX.orm, negativeXXX.jdoquery" and simply loads them into a standard DOM using a validating parser. All test files named positiveXXX should succeed; tests named negativeXXX should fail to load.

The second part is a set of test data that is organized into positive and negative test cases. The union of positive tests should test every feature (each element and attribute) of each of the .orm, .jdo, and .jdoquery schema and DTD. Negative tests will verify for example that no more than one element is permitted if annotated as ? in DTD or maxOccurs=1 in schema.

Craig Russell added a comment - 07/Jan/06 11:00 AM
This is just some code to stimulate discussion.

Craig Russell made changes - 07/Jan/06 11:00 AM
Field Original Value New Value
Attachment schematest.patch [ 12321797 ]
Craig Russell made changes - 04/Feb/06 04:27 AM
Affects Version/s JDO 2 beta [ 12310683 ]
Fix Version/s JDO 2 rc1 [ 12310771 ]
Craig Russell made changes - 04/Feb/06 04:44 AM
Type Bug [ 1 ] Test [ 6 ]
Craig Russell added a comment - 12/Feb/06 02:38 PM
This patch fixes a syntax error in two of the .xsd files, in which the attributes were defined inside the element instead of outside.

Craig Russell made changes - 12/Feb/06 02:38 PM
Attachment XSD.patch [ 12322889 ]
Repository Revision Date User Message
ASF #377268 Sun Feb 12 23:21:30 UTC 2006 clr JDO-202 fixed one issue with orm.xsd and jdo.xsd
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.xsd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.xsd

Michael Bouschen added a comment - 13/Feb/06 07:41 AM
The attached patch schemaValidation-060212.patch adds a new test XMLTest.

Michael Bouschen made changes - 13/Feb/06 07:41 AM
Attachment schemaValidation-060212.patch [ 12322900 ]
Repository Revision Date User Message
ASF #377515 Mon Feb 13 22:36:35 UTC 2006 clr JDO-202 removed erroneous xs:attribute ending
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdoquery.xsd

Repository Revision Date User Message
ASF #378770 Sat Feb 18 20:18:04 UTC 2006 mbo JDO-202: fixed jdo.xsd and changed property attribues, class subelements, field attribues, array attributes, order attributes, fetch-group subelements, and embedded subelements.
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.xsd

Michael Bouschen added a comment - 19/Feb/06 06:02 AM
There is a new patch schemaValidation-060218.patch includes the new test class XMLTest, 6 positive and 2 negative test .jdo files. We still need to add test .orm and .jdoquery files.

Michael Bouschen made changes - 19/Feb/06 06:02 AM
Attachment schemaValidation-060218.patch [ 12323147 ]
Repository Revision Date User Message
ASF #379246 Mon Feb 20 21:41:03 UTC 2006 mbo JDO-202: spec review items Chapter 18
- Restrict allows-null attribute values in column element.
- Changed subelements of foreign-key, index, and unique.
- Added/changed update-action attribute in elements: element, key, value.
- Removed indexed attribute from order element.
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.dtd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.dtd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.xsd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.xsd

Michael Bouschen added a comment - 21/Feb/06 07:45 AM
Attached you find a new patch schemaValidation-060220.patch for review. It changes the test .jdo files according to the latest jdo.dtd and jdo.xsd updates.

Michael Bouschen made changes - 21/Feb/06 07:45 AM
Attachment schemaValidation-060220.patch [ 12323215 ]
Repository Revision Date User Message
ASF #379576 Tue Feb 21 20:31:33 UTC 2006 mbo JDO-202: add schema validation test case XMLTest that is running .jdo, .orm and
.jdoquery files against the XSD and DTD.
Files Changed
MODIFY /db/jdo/trunk/api20/test/java/javax/jdo/util/AbstractTest.java
ADD /db/jdo/trunk/api20/test/schema
ADD /db/jdo/trunk/api20/test/java/javax/jdo/schema
MODIFY /db/jdo/trunk/api20/project.xml
ADD /db/jdo/trunk/api20/test/java/javax/jdo/schema/XMLTest.java
ADD /db/jdo/trunk/api20/project.properties
ADD /db/jdo/trunk/api20/test/schema/Positive0-dtd.jdo
ADD /db/jdo/trunk/api20/test/schema/Positive99-dtd.jdo
ADD /db/jdo/trunk/api20/test/schema/Positive1-dtd.jdo
ADD /db/jdo/trunk/api20/test/schema/Negative0-dtd.jdo
ADD /db/jdo/trunk/api20/test/schema/Positive0-xsd.jdo
ADD /db/jdo/trunk/api20/test/schema/Positive99-xsd.jdo
ADD /db/jdo/trunk/api20/test/schema/Positive1-xsd.jdo
ADD /db/jdo/trunk/api20/test/schema/Negative0-xsd.jdo

Repository Revision Date User Message
ASF #379608 Tue Feb 21 22:41:34 UTC 2006 mbo JDO-202: added missing field subelement foreign-key and removed mapped-by attribute from element
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.xsd

Repository Revision Date User Message
ASF #379611 Tue Feb 21 22:45:11 UTC 2006 mbo JDO-202: Rearranged the elements in orm.dtd to use the same order as in jdo.dtd.
- Added subelement 'property' to element 'class'.
- Changed attribute 'strategy' in the element 'version' from REQUIRED to IMPLIED.
- Fixed 'implement' subelements.
- Fixed order of subelements in elements 'inheritance'.
- Restricted the values of attribute 'primary-key' in element 'field'.
Changed orm.xsd accordingly.
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.dtd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.xsd

Repository Revision Date User Message
ASF #379826 Wed Feb 22 17:44:23 UTC 2006 mbo JDO-202: reintroduce mapped-by attribute for element element
Files Changed
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.dtd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.dtd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/jdo.xsd
MODIFY /db/jdo/trunk/api20/src/dtd/javax/jdo/orm.xsd

Repository Revision Date User Message
ASF #379836 Wed Feb 22 18:47:41 UTC 2006 clr JDO-202 Added mapped-by to element element
Files Changed
MODIFY /db/jdo/trunk/api20/test/schema/Positive99-dtd.jdo
MODIFY /db/jdo/trunk/api20/test/schema/Positive99-xsd.jdo

Repository Revision Date User Message
ASF #379839 Wed Feb 22 18:52:15 UTC 2006 mbo JDO-202 fixed named query metadata
Files Changed
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdoquery.dtd
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdo.dtd
MODIFY /db/jdo/trunk/api20/test/schema/Positive99-dtd.jdo
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdoquery.xsd
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/orm.dtd
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdo.xsd
MODIFY /db/jdo/trunk/api20/test/schema/Positive99-xsd.jdo
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/orm.xsd

Repository Revision Date User Message
ASF #379849 Wed Feb 22 19:33:08 UTC 2006 mbo JDO-202 remove fetch-group attribute from property element
Files Changed
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdo.dtd
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdo.xsd

Repository Revision Date User Message
ASF #379983 Wed Feb 22 23:36:13 UTC 2006 clr JDO-202 Remove fetch-group from property
Files Changed
MODIFY /db/jdo/trunk/api20/test/schema/Positive99-dtd.jdo
MODIFY /db/jdo/trunk/api20/test/schema/Positive99-xsd.jdo

Repository Revision Date User Message
ASF #380324 Fri Feb 24 03:50:16 UTC 2006 clr JDO-202 Added test cases for .orm and .jdoquery
Removed attribute serialized from element property in orm
Removed attribute primary-key from element field in orm
Fixed typo in jdoquery.xsd
Added test cases for Chapter 15 examples
Files Changed
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.5-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.6-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.8.1-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.1-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.8.2-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive99-dtd.jdoquery
ADD /db/jdo/trunk/api20/test/schema/Positive15.8.3-xsd.orm
MODIFY /db/jdo/trunk/api20/test/java/javax/jdo/schema/XMLTest.java
ADD /db/jdo/trunk/api20/test/schema/Positive15.4-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.5-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.2.1-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.6-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.1-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.2.2-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.2-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Negative0-xsd.jdoquery
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.3-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.4-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.5-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.6-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.8.1-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive0-xsd.jdoquery
ADD /db/jdo/trunk/api20/test/schema/Positive15.8.2-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.8.3-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive0-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive1-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Negative0-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive0-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive1-dtd.orm
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/orm.xsd
ADD /db/jdo/trunk/api20/test/schema/Negative0-dtd.jdoquery
ADD /db/jdo/trunk/api20/test/schema/Negative0-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive0-dtd.jdoquery
MODIFY /db/jdo/trunk/api20/test/schema/Positive1-dtd.jdo
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/orm.dtd
ADD /db/jdo/trunk/api20/test/schema/Positive99-xsd.jdoquery
ADD /db/jdo/trunk/api20/test/schema/Positive99-xsd.orm
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdoquery.xsd
ADD /db/jdo/trunk/api20/test/schema/Positive15.1-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.4-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.5-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.2.1-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive99-dtd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.6-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.1-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.2.2-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.2-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.3-xsd.orm
ADD /db/jdo/trunk/api20/test/schema/Positive15.3.4-xsd.orm

Repository Revision Date User Message
ASF #380901 Sat Feb 25 06:25:49 UTC 2006 clr JDO-202 Added attribute field-type to element field
Files Changed
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdo.dtd
MODIFY /db/jdo/trunk/api20/src/schema/javax/jdo/jdo.xsd

Craig Russell added a comment - 25/Feb/06 07:47 AM
A test program XMLTest has been added to the api20 project.

Craig Russell made changes - 25/Feb/06 07:47 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Craig Russell made changes - 25/Feb/06 07:47 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Craig Russell made changes - 25/Feb/06 07:48 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Fix Version/s JDO 2 rc1 [ 12310771 ]
Fix Version/s JDO 2 final [ 12310830 ]
Resolution Fixed [ 1 ]