Add tests for static JDOHelper.getObjectIds methods

• Key: JDO-188
• Type: Test
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Craig Russell
• Reporter: Craig Russell
• Component/s: tck2
• Fix Version/s: JDO 2 beta

Description

A8.3-11 [static Object[] getObjectIds (Object[] pcs); static Collection getObjectIds (Collection pcs); These methods return the JDO identities of the parameter instances. For each instance in the parameter, the getObjectId method is called. They return one identity instance for each persistence-capable instance in the parameter. The order of iteration of the returned Collection exactly matches the order of iteration of the parameter Collection].

The test case api.persistencemanager.GetObjectIds needs a test method per API.

The setUp method creates 50 persistent instances of type PCPoint and stores the ids in an ArrayList and the instances in a separate ArrayList. The test case call getObjectIds and verify that the object ids returned match the objects ids that are in the list.

There are no negative tests.

Comments

[karan singh malhi]

The test case api.persistencemanager.GetObjectIds needs a test method per API.

Should'nt the above be api.jdohelper.GetObjectIds

[Craig Russell]

You are right.

The new methods are indeed in JDOHelper not in PersistenceManager. So the test needs to be written for the JDOHelper class.

I'd propose the new test case api.jdohelper.GetObjectIds with test methods testGetObjectIdsCollection and testGetObjectIdsArray. The collection of parameter objects should include null, transient instances, and persistent instances from multiple persistence managers.

The JDOHelper checked into the repository does not include the new methods, so as part of this work the methods need to be added.

Please review this patch for JDOHelper.java and GetObjectIds.java.

The patch has been tested against the latest JPOX build.

[Michael Bouschen]

The patch looks good.

Just one remark: the localSetUp method creates a second PM which is not closed in the test case. Should we add a localTearDown method coling this PM?

[Craig Russell]

This patch includes comments from Michael (thanks, I missed the cleanup of the second PM), an update to the alltests.conf, and a slightly different implementation of JDOHelper.getObjectIds(Object[ ]).

I plan to check it in tomorrow.

[Craig Russell]

Added tests for JDOHelper.getObjectIds

Committed revision 329926, accidentally including patch for instancecallbacks teardown.
 Committed revision 329927.

[Michael Bouschen]

Reopened to set the Fix Version/s field to JDO 2 beta.