JPOX fails when a query calls String.matches

• Key: JDO-176
• Type: Bug
• Status: Closed
• Resolution: Invalid
• Priority: Major
• Assignee: Erik Bengtson
• Reporter: Michael Watzek
• Component/s: tck2

Description

JPOX fails when a query calls String.matches. This bug may be reproduced applying patch JDO-159. The SQL generation of the following query is incorrect:

SELECT FROM org.apache.jdo.tck.pc.company.Person WHERE firstname.matches('*First')

The LIKE clause of the generated SQL statement contains '*First'. This is a bug. It should contain '%First'.

Comments

[Craig Russell]

The parameter for "matches" is a regular expression. If '*First' is intended to be a wild card, it should be '.*First' instead. The wild card for regular expressions is dot star.

[Michael Watzek]

Component set to tck20.

[Erik Bengtson]

"*First" is invalid as regular expression.


Exception in thread "main" java.util.regex.PatternSyntaxException: Dangling meta character '*' near index 0
*First
^
at java.util.regex.Pattern.error(Unknown Source)
at java.util.regex.Pattern.sequence(Unknown Source)
at java.util.regex.Pattern.expr(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at java.util.regex.Pattern.<init>(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at java.util.regex.Pattern.matches(Unknown Source)
at java.lang.String.matches(Unknown Source)
at Test.main(Test.java:11)



public class Test
{

    /**
     * @param args
     */
    public static void main(String[] args)
    {
        System.out.println("kjdsd deoide First".matches("*First"));
        System.out.println("kjdsd deoide First".matches(".*First"));
        // TODO Auto-generated method stub

    }

}

[Erik Bengtson]

should the jdo implementation raise an exception or is it valid to query for '*First' (literally)?

[Michael Watzek]

This is not a bug because the regular expression passed to method "matches" is invalid.