XML query testdata needs to be extended for new JDO 2 query tests

• Key: JDO-168
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Michael Watzek
• Reporter: Michael Watzek
• Component/s: tck2

Description

The new JDO 2 query test cases require more complex testdata than contained in 'companyForQueryTests.xml'. I propose to copy the content of 'companyAllRelationships.xml' into 'companyForQueryTests.xml'.

Due to this change some existing query tests must be adapted wrt the expected query result:

- test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedCollectionMethods.java
- test\java\org\apache\jdo\tck\query\jdoql\NavigationThroughReferencesUsesDotOperator.java
- test\java\org\apache\jdo\tck\query\jdoql\Cast.java
- test\java\org\apache\jdo\tck\query\jdoql\DenoteUniquenessInFilter.java
- test\java\org\apache\jdo\tck\query\jdoql\NullCollectionsAndContainsMethod.java
- test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenDateFieldsAndParameters.java
- test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenStringFieldsAndParameters.java

Comments

[Michael Watzek]

The patch fixes the issues above.

Applying this patch, JPOX returns two more failures with alltests.conf for both, application identity and datastore identity. The test cases NavigationThroughANullValuedField and NavigationThroughReferencesUsesDotOperator fail due to unexpected query results. JPOX generates an incomplete SQL statement for the query missing a discriminator comparison for a relationship navigation. For this reason, the query returns more results than expected. I'll file a separate issue.

[Michael Watzek]

I filed JDO-169 describing the bug and the solution.

[Michael Bouschen]

I agree, the new JDO2 query tests require more test data.
The patch JDO-168.patch looks good!

[Michael Watzek]

The patch has been checked in.