[#JDO-167] Inheritance mapping 2 needs to be changed to support polymorphic relationships to Employees

JDO

Inheritance mapping 2 needs to be changed to support polymorphic relationships to Employees

Created: 05/Oct/05 12:37 AM Updated: 09/Dec/05 12:37 AM

Return to search

Component/s:

tck2

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
JDO-167.patch	2005-12-08 12:23 AM	Michael Watzek	20 kB
JDO-167.patch2	2005-12-08 07:54 PM	Michael Watzek	20 kB

Resolution Date:

09/Dec/05 12:37 AM

Description

« Hide

Inheritance mapping 2 is incomplete wrt Employee relationships. Due to this lack, implementations cannot figure out the right runtime type at navigation time, e.g. navigating from Project to Employee.

In t-conference, Sep 30, Craig proposed to drop the identity propties from PK columns of tables persons, fulltimeemployees, parttimeemployees. Instead, we introduce implementation-defined sequences to generate unique key values for all instances of the Person class hierarchy. Having unique PK values for each row in the hierarchy, implementations are able to find out the right runtime type when navigating Employee relationships.

We need to adapt the schema and the ORM metadata in order to reflect these changes.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael Watzek added a comment - 08/Dec/05 12:23 AM

The attached patch fixes this issue.

Michael Watzek made changes - 08/Dec/05 12:23 AM

Field	Original Value	New Value
Attachment		JDO-167.patch [ 12321201 ]

Repository	Revision	Date	User	Message
ASF	#355126	Thu Dec 08 15:36:56 UTC 2005	brazil	~~JDO-167~~: Inheritance mapping 2 needs to be changed to support polymorphic relationships to Employees.
				Files Changed
				MODIFY /incubator/jdo/trunk/tck20/test/conf/companyEmbedded.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/company1-MRelationships.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/companyNoRelationships.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/schemaAttributeClass.conf MODIFY /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/mapping/CompletenessTest.java MODIFY /incubator/jdo/trunk/tck20/test/conf/company1-1Relationships.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/detach.conf MODIFY /incubator/jdo/trunk/tck20/maven.xml MODIFY /incubator/jdo/trunk/tck20/test/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-derby2.orm MODIFY /incubator/jdo/trunk/tck20/test/conf/schemaAttributeOrm.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/companyAllRelationships.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/datastoreidentity.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/schemaAttributePackage.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/inheritance4.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/inheritance3.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/inheritance2.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/inheritance1.conf MODIFY /incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema2.sql MODIFY /incubator/jdo/trunk/tck20/test/conf/applicationidentity.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/companyM-MRelationships.conf MODIFY /incubator/jdo/trunk/tck20/test/conf/alltests.conf

[ Permlink | « Hide ]

Michael Bouschen added a comment - 08/Dec/05 07:22 PM

A few commenst about the patch:

Class CompletenessTest
- The StringTokenizer might return "" as a token. The code should skip this token this before before checking the supported options.
- Method isTestToBePerformed has an if statement at the end which you can skip.
- Method localSetUp should call addTearDownClass before making instances persistent.

[ Permlink | « Hide ]

Michael Watzek added a comment - 08/Dec/05 07:54 PM

The second patch implements the comments above.

Michael Watzek made changes - 08/Dec/05 07:54 PM

Attachment

JDO-167.patch2 [ 12321225 ]

[ Permlink | « Hide ]

Michael Bouschen added a comment - 09/Dec/05 12:22 AM

Looks good!

[ Permlink | « Hide ]

Michael Watzek added a comment - 09/Dec/05 12:37 AM

The second patch has been checked in (revision 355126).

Michael Watzek made changes - 09/Dec/05 12:37 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]