Implement new JDO 2 query tests cases concerning other language changes.

• Key: JDO-162
• Type: New Feature
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Michael Watzek
• Reporter: Michael Watzek
• Component/s: tck2

Description

We need 5 new test classes, one for each of the following assertions:

- A14.6.2-42: There is no distinction made between character literals and String literals. Single character String literals can be used wherever character literals are permitted. String literals are allowed to be delimited by single quote marks or double quote marks. This allows String literal filters to use single quote marks instead of escaped double quote marks.
- A14.6.2-43: Identifiers that are persistent field names or public final static field names are required to be supported by JDO implementations.
- A14.6.8-1: setRange(long fromIncl, long toExcl).
- A14.6.8-2: If ((toExcl - fromIncl) <= 0) evaluates to true, if the result of the query execution is a List, the returned List contains no instances, and an Iterator obtained from the List returns false to hasNext(). If the result of the query execution is a single instance (setUnique(true)), it will have a value of null.
- A14.6.8-3: setRange(String range).

Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#OtherLanguageChanges.

Comments

[Michael Watzek]

The patch implements the assertions above.

[Michael Bouschen]

Some comments about the patch

CharacterAndStringLiterals.java:
- I propose to change the filter of the invalid query to "charNotNull == 'O.'".
- I propose to add a new invalid query using double quotes: "charNotNull == \"O.\""
- OR is not a valid operaor in JDOQL.
- I propose to add another valid query using double quotes: stringNull.startsWith(\"Even\") OR charNotNull == \"O\"

PositiveRange, RangeAsString:
- I propose to add another test query with a non zero from range.

IdentifiersEqualFieldNames:
- I think we need two test queries here: one accesing a persistent field such as "this.firstname = 'emp1First'" and another one uinsg a constatnt such as "this.personid < Byte.MAX_VALUE.

[Michael Watzek]

The second patch implements the comments above. Additionally, it adds ORDER BY clauses to all valid range queries.

[Michael Bouschen]

Looks good, ship it.

[Michael Watzek]

The second patch implements the comments above and has been checked in.

That patch contained two bugs which has been fixed and checked in also:

1) The call of method Query.setRange had been enabled.
2) A logger for class MyLibReader was introduced in all logging properties files.