Implement new JDO 2 query tests cases concerning keywords.

• Key: JDO-157
• Type: New Feature
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Michael Watzek
• Reporter: Michael Watzek
• Component/s: tck2

Description

We need 4 new test classes, one for each of the following assertions:

- A14.4-6: Keywords must not be used as package names, class names, parameter names, or variable names in queries.
- A14.4-7: Keywords are permitted as field names only if they are on the right side of the "." in field access expressions.
- A14.6.13-1: The String version of Query represents all query elements using a single string. The string contains the following structure.
- A14.6.13-2: Keywords, identified above in bold, are either all upper-case or all lower-case. Keywords cannot be mixed case.

Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Keywords.

Comments

[Michael Watzek]

This patch implements the assertions above. It depends on patches for JDO-156 and JDO-168, in that order. For this reason, those patches must be checked in first.

[Michael Bouschen]

Just some minor comments:

Class CompanyModelReader
- The CompanyModelReader change is already checked in as part of patch 156.

Class FullName
- minor: you can shorten the implementation of equals:
     public boolean equals(Object o) {
        FullName other = (FullName) o;
        if (this.firstName == null) {
return other.firstName == null;
        }
        if (this.lastName == null) {
return other.lastName == null;
        }
     ...
- How about adding some class javadoc describing why you added two getter methods getFirstName and getFirstname etc.?

[Michael Watzek]

The second patch contains all the comments.

[Michael Bouschen]

Looks good!

[Michael Watzek]

The second patch has been checked in.