[#JDO-150] PersistenceManager.retrieve(...) updates to match the JDO2 spec

JDO

PersistenceManager.retrieve(...) updates to match the JDO2 spec

Created: 26/Sep/05 04:48 AM Updated: 08/Dec/05 08:26 AM

Return to search

Component/s:

api2

Affects Version/s:

None

Fix Version/s:

JDO 2 beta

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	patch.txt	2005-09-26 09:26 PM	Andy Jefferson	3 kB

Resolution Date:

08/Dec/05 08:26 AM

Description

« Hide

The JDO2 spec defines "PersistenceManager" containing :-
void retrieve(Object pc, boolean FGOnly);
This is currently missing.

Also the methods
void retrieveAll (Collection pcs, boolean DFGOnly);
void retrieveAll (Object[] pcs, boolean DFGOnly);
refer to a DFGOnly parameter, whereas it should be FGOnly. Javadocs need similar updates

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Craig Russell made changes - 26/Sep/05 03:12 PM

Field	Original Value	New Value
Assignee		Craig Russell [ clr ]

[ Permlink | « Hide ]

Andy Jefferson added a comment - 26/Sep/05 09:26 PM

The attached patch is hopefully adequate.
JPOX CVS includes the missing retrieve() method (nightly builds dated 27/09/2005 onwards) so patch can be applied anytime after that and shouldn't break the linkage with JPOX.

Andy Jefferson made changes - 26/Sep/05 09:26 PM

Attachment

patch.txt [ 12314561 ]

[ Permlink | « Hide ]

Craig Russell added a comment - 27/Sep/05 03:02 AM

The patch needs to include updates for the runtime20 project that contains implementations for the updated interfaces.

Also, the javadoc should not extends beyond 80 characters.

Thanks for the head start on the implementation.

Repository	Revision	Date	User	Message
ASF	#291898	Tue Sep 27 10:47:32 UTC 2005	clr	~~JDO-150~~ Add new method retrieve(Object, boolean); update javadoc for retrieveAll with FGOnly parameter
				Files Changed
				MODIFY /incubator/jdo/trunk/runtime20/src/java/org/apache/jdo/impl/pm/PersistenceManagerImpl.java MODIFY /incubator/jdo/trunk/api20/src/java/javax/jdo/PersistenceManager.java MODIFY /incubator/jdo/trunk/runtime20/src/java/org/apache/jdo/impl/pm/PersistenceManagerWrapper.java

[ Permlink | « Hide ]

Craig Russell added a comment - 01/Oct/05 12:24 AM

Commit r291898 added retrieve(Object, boolean) and updated javadoc for other retrieve methods.

Craig Russell made changes - 01/Oct/05 12:24 AM

Status	Open [ 1 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

[ Permlink | « Hide ]

Craig Russell added a comment - 07/Dec/05 09:48 AM

Need to reopen this to assign it to a fix release.

Craig Russell made changes - 07/Dec/05 09:48 AM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

Craig Russell made changes - 07/Dec/05 09:48 AM

Affects Version/s

JDO 2 beta [ 12310683 ]

Craig Russell made changes - 07/Dec/05 09:49 AM

Fix Version/s		JDO 2 beta [ 12310683 ]
Affects Version/s	JDO 2 beta [ 12310683 ]

Craig Russell made changes - 08/Dec/05 08:26 AM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]