Add get/setRollbackOnly tests

• Key: JDO-140
• Type: Test
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Craig Russell
• Reporter: Craig Russell
• Component/s: tck2
• Fix Version/s: JDO 2 beta

Description

There are two test classes for get/setRollbackOnly.

One test class transactions.AfterSetRollbackOnlyCommitFails tests assertion A13.4.5-1
Once a transaction has been marked for rollback via setRollbackOnly, the commit method will always fail with JDOFatalDataStoreException.
The strategy is to begin a transaction, set rollback only, and commit. The expected behavior is to catch an exception.

The second test class transactions.GetRollbackOnlyReturnsFalseUntilSet tests assertion A13.4.5-2
After a transaction is begun, getRollbackOnly will return false until set commit or rollback is called.
The strategy is to begin a transaction, test that getRollbackOnly is false, setRollbackOnly, and test that getRollbackOnly is true.

Comments

[Craig Russell]

These are the two test cases in patch format.

[Michael Bouschen]

I have one comment about GetRollbackOnlyReturnsFalseUntilSet:

The assertion text of A13.4.5-2 has been changed in the current version o fthe spec: "When a transaction is not active, and after a transaction is begun, getRollbackOnly will return false. Once setRollbackOnly has been called, it will return true until commit or rollback is called."

The test case implementation already covers the new version of the assertion text. I just propose to adapt the assertion text in the javadoc of the test case and in the spreadsheet.

[Craig Russell]

New test cases were added; alltests.conf was updated with the new tests.

[Michael Bouschen]

Reopened to set the Fix Version/s field to JDO 2 beta.