Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
-
None
Description
The method RemoteCacheServer.logUpdateInfo contains the code:
if ( log.isInfoEnabled() ) { // not thread safe, but it doesn't have to be accurate puts++; if ( puts % logInterval == 0 ) { log.info( "puts = " + puts ); } }
This looks wrong - why is the put counter only update if logging is enabled?
Looks like the issue occurred in r436643 where the getPutCount() method was added. Up until this point the puts field was only used in the above logging method, so it made sense to confine the updates to the logging conditional statement.
However, now the count is used for unit tests, so it needs to be independent of the logging level.