[#JCR-363] Node.setProperty(String, ...) implementation not according to the specification

Jackrabbit Content Repository

Node.setProperty(String, ...) implementation not according to the specification

Created: 20/Mar/06 06:59 PM Updated: 29/Mar/06 02:38 AM

Return to search

Component/s:

JCR API

Affects Version/s:

0.9

Fix Version/s:

1.0

Time Tracking:

Not Specified

Environment:

svn r387181

Resolution Date:

20/Mar/06 09:35 PM

Description

« Hide

to illustrate the issue assume the following property definition:

name: someText
type: String
non-mandatory
non-autocreate

the following call would throw a ConstraintViolationException
if the property doesn't exist yet:

node.setProperty("someText", 12345);

the rules used to find an applicable definition in this case are too strict.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#387211	Mon Mar 20 13:35:05 UTC 2006	stefan	~~JCR-363~~: Node.setProperty(String, ...) implementation not according to the specification
				Files Changed
				MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/NodeImpl.java MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/ItemManager.java

Repository	Revision	Date	User	Message
ASF	#387311	Mon Mar 20 21:09:40 UTC 2006	jukka	1.0: Merged revision 387211: ~~JCR-363~~: Node.setProperty(String, ...) implementation not according to the specification
				Files Changed
				MODIFY /incubator/jackrabbit/branches/1.0/jackrabbit/src/main/java/org/apache/jackrabbit/core/ItemManager.java MODIFY /incubator/jackrabbit/branches/1.0/jackrabbit/src/main/java/org/apache/jackrabbit/core/NodeImpl.java

Stefan Guggisberg made changes - 20/Mar/06 09:35 PM

Field	Original Value	New Value
Assignee		Stefan Guggisberg [ stefan@jira ]

[ Permlink | « Hide ]

Stefan Guggisberg added a comment - 20/Mar/06 09:35 PM

fixed in svn r387211

Stefan Guggisberg made changes - 20/Mar/06 09:35 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

[ Permlink | « Hide ]

Jukka Zitting added a comment - 20/Mar/06 09:50 PM

Should I merge this with 1.0? How high is the chance of unexpected regressions caused by r387211?

[ Permlink | « Hide ]

Stefan Guggisberg added a comment - 20/Mar/06 10:23 PM

i targeted 1.0 as this is imo a major bug, causing jsr170 compliancy issues.

i tested the fix and found no problems whatsoever. however
it's a relatively small but non-trivial change. judging the risk
of unexpected regressions is very difficult.

maybe we should target 1.0.1 instead.

[ Permlink | « Hide ]

Jukka Zitting added a comment - 20/Mar/06 10:39 PM

OK, thanks. I'll merge it in 1.0 on the basis of JSR 170 compliancy. If it does cause a problem, then we can always release a fix in 1.0.1. I'd rather err with a bug in 1.0 than an API compliancy issue, especially as the change seems to work just fine for me as well.

[ Permlink | « Hide ]

Jukka Zitting added a comment - 29/Mar/06 02:38 AM

Merged to 1.0 in revision 387311.

Jukka Zitting made changes - 07/Jul/09 01:04 PM

Workflow

jira [ 12352215 ]

no-reopen-closed, patch-avail [ 12469476 ]