[#JCR-333] NodeTypeDef depends on supertype ordering

Jackrabbit Content Repository

NodeTypeDef depends on supertype ordering

Created: 07/Mar/06 07:33 AM Updated: 13/Oct/06 04:07 PM

Return to search

Component/s:

nodetype

Affects Version/s:

0.9

Fix Version/s:

1.0

Time Tracking:

Not Specified

Resolution Date:

09/Mar/06 01:12 AM

Description

« Hide

Currently the NodeTypeDef.setSupertypes() method simply sets the given QName array as the supertype QName array of the defined node type, thus preserving whatever ordering a node type parser or ultimately a node type definition file uses. This causes problems for example in the equals() method that uses the order-sensitive Arrays.equals() method to check for equality of the supertype QName arrays. The current implementation does therefore not consider the node type definitions "A > B, C" and "A > C, B" as equal even though they really should be so considered.

The same problem affects also child node and property definitions. The proper fix for this issue would probably be to use Sets to store and handle this information.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#383708	Mon Mar 06 23:37:42 UTC 2006	jukka	~~JCR-333~~: Maintain explicit supertype ordering to avoid unexpected problems with undefined ordering of HashSet elements. This is a workaround for the failing CompactNodeTypeDefReader test case on Linux JDK 1.4.2_10. This workaround can be reverted once ~~JCR-333~~ has been resolved.
				Files Changed
				MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/nodetype/compact/CompactNodeTypeDefReader.java

Stefan Guggisberg made changes - 07/Mar/06 04:41 PM

Field	Original Value	New Value
Assignee		Stefan Guggisberg [ stefan@jira ]

Repository	Revision	Date	User	Message
ASF	#384271	Wed Mar 08 17:11:12 UTC 2006	stefan	~~JCR-333~~ NodeTypeDef depends on supertype ordering
				Files Changed
				MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/nodetype/NodeDefImpl.java MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeDef.java

[ Permlink | « Hide ]

Stefan Guggisberg added a comment - 09/Mar/06 01:12 AM

fixed as suggested (svn r384271)

Stefan Guggisberg made changes - 09/Mar/06 01:12 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#384546	Thu Mar 09 16:30:34 UTC 2006	jukka	~~JCR-333~~: Fixed a test case that expected a specific ordering of node type information.
				Files Changed
				MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/test/java/org/apache/jackrabbit/core/nodetype/xml/TestAll.java

Repository	Revision	Date	User	Message
ASF	#384767	Fri Mar 10 11:28:45 UTC 2006	stefan	~~JCR-333~~: Fixed a test case that depended on random ordering of equally-named property definitions.
				Files Changed
				MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/test/java/org/apache/jackrabbit/test/api/nodetype/spec/nt-unstructured.txt MODIFY /incubator/jackrabbit/trunk/jackrabbit/src/test/java/org/apache/jackrabbit/test/api/nodetype/PredefinedNodeTypeTest.java

Jukka Zitting made changes - 21/Mar/06 06:20 AM

Affects Version/s		1.0 [ 12310154 ]
Fix Version/s		1.1 [ 12310346 ]

Repository	Revision	Date	User	Message
ASF	#389555	Tue Mar 28 17:49:47 UTC 2006	jukka	1.0: Merged revisions 384271, 384546, and 384767: ~~JCR-333~~ NodeTypeDef depends on supertype ordering
				Files Changed
				MODIFY /jackrabbit/branches/1.0/jackrabbit/src/main/java/org/apache/jackrabbit/core/nodetype/NodeDefImpl.java MODIFY /jackrabbit/branches/1.0/jackrabbit/src/test/java/org/apache/jackrabbit/core/nodetype/xml/TestAll.java MODIFY /jackrabbit/branches/1.0/jackrabbit/src/test/java/org/apache/jackrabbit/test/api/nodetype/spec/nt-unstructured.txt MODIFY /jackrabbit/branches/1.0/jackrabbit/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeDef.java MODIFY /jackrabbit/branches/1.0/jackrabbit/src/test/java/org/apache/jackrabbit/test/api/nodetype/PredefinedNodeTypeTest.java

[ Permlink | « Hide ]

Jukka Zitting added a comment - 29/Mar/06 02:50 AM

Merged to 1.0 in revision 389555.

Jukka Zitting made changes - 29/Mar/06 02:50 AM

Affects Version/s	1.0 [ 12310154 ]
Fix Version/s	1.1 [ 12310346 ]
Fix Version/s		1.0 [ 12310154 ]

Jukka Zitting made changes - 13/Oct/06 04:07 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Jukka Zitting made changes - 07/Jul/09 01:04 PM

Workflow

jira [ 12351610 ]

no-reopen-closed, patch-avail [ 12469497 ]