Issue Details (XML | Word | Printable)

Key: JAMES-588
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Noel J. Bergman
Reporter: Noel J. Bergman
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
JAMES Server

XMLResource getString methods have incorrect javadocs, and one will throw an NPE.

Created: 11/Aug/06 01:15 AM   Updated: 11/Aug/06 05:47 PM
Return to search
Component/s: James Core
Affects Version/s: 2.2.0, 2.3.0
Fix Version/s: 2.3.0

Time Tracking:
Not Specified

Resolution Date: 11/Aug/06 05:41 PM


 Description  « Hide
The javadocs for getString(String) and getString(String, Boolean) are wrong. There is no string replacement. The one method that does do replacement, getString(String, Map), does not check for a null string before attempting replacement.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #430654 Fri Aug 11 04:08:24 UTC 2006 noel JAMES-588. Remove references to parameter replacement for methods that don't do it. Add getString(String,Map,Boolean) to match the other options. Modify replaceParameters(String, Map) so that it won't NPE if either parameter is null. Change the RuntimeException to the more specific IllegalArgumentException.
Files Changed
MODIFY /james/server/trunk/src/java/org/apache/james/util/XMLResources.java