Issue Details (XML | Word | Printable)

Key: JAMES-587
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Noel J. Bergman
Reporter: Noel J. Bergman
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
JAMES Server

CommandListServManager does not properly handle invalid commands.

Created: 11/Aug/06 01:10 AM   Updated: 11/Aug/06 05:47 PM
Return to search
Component/s: Matchers/Mailets (bundled)
Affects Version/s: 2.2.0, 2.3.0
Fix Version/s: 2.3.0

Time Tracking:
Not Specified

Resolution Date: 11/Aug/06 05:47 PM


 Description  « Hide
If there is an invalid command, the service() method still tries to execute it (missing else), resulting in a spurious exception. Also, the message returned to the sender is not properly generated to include the command that was invalid.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #430647 Fri Aug 11 03:55:04 UTC 2006 noel JAMES-587. Move the command.onCommand call into an else block so that it isn't executed when command is null. When command IS null, add the COMMAND property to the map before calling xmlResources.getString(String,Map), so that the name of the invalid command is reported in the bounce message.
Files Changed
MODIFY /james/server/trunk/src/java/org/apache/james/transport/mailets/CommandListservManager.java

Noel J. Bergman added a comment - 11/Aug/06 05:47 PM
Fixed in trunk and for James v2.3 RC2.

Noel J. Bergman made changes - 11/Aug/06 05:47 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.3.0rc2 [ 12312012 ]
Resolution Fixed [ 1 ]
Noel J. Bergman made changes - 11/Aug/06 05:47 PM
Status Resolved [ 5 ] Closed [ 6 ]