SMTP Server may leak temporary ($[JAMES}/temp/*.m64) files

• Key: JAMES-585
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Noel J. Bergman
• Reporter: Noel J. Bergman
• Component/s: SMTPServer
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0

Description

If there is an exception during message processing, before the message is posted to the spooler, the temporary files may not be cleaned up. This appears to be due to an unintended and implied reliance on finalize() to dispose the temporary files.

Comments

[Noel J. Bergman]

Should be resolved by r428097.

An alternative would have been to incorporate the FileCleaner from Commons I/O, which is used for the same purpose in Commons FileUpload.

[Noel J. Bergman]

I'm still seeing it ... need to find out why.

[Noel J. Bergman]

Current status:

  1) After applying r428097, even though some files appear to leak, they are deleted when the JVM terminates.
  2) A private build, using a copy of org.apache.commons.io.FileCleaner, does not appear to leak files at all during runtime.

I will continue to test to see if the FileCleaner solution, which was written for just this purpose, resolves the issue.

[Noel J. Bergman]

Stefano had another though, involving changing

MimeMessageInputStreamSource.getInputStream from:
    return new SharedFileInputStream(file);
to
    return new BufferedInputStream(new FileInputStream(file));

[Noel J. Bergman]

NOW I am closing this issue. :-) The changes in r428404 appear to have done the trick, and r428480 backs out some of the earlier changes.

[Noel J. Bergman]

Resolve *and* close.

[Norman Maurer]

This bug is still not fixed. Stefano has a idea.. so i assign it to him ;-)

[Stefano Bagnara]

Norman, you reopened the wrong bug ;-)
JAMES-584 is the one still being reproducible.

Closing issue fixed in released version.