[#JAMES-580] NPE is issued when receiving a "read receipt" from MS Outlook, and <checkValidSenderDomain> is set to true

JAMES Server

NPE is issued when receiving a "read receipt" from MS Outlook, and <checkValidSenderDomain> is set to true

Created: 27/Jul/06 03:34 PM Updated: 21/Nov/07 08:31 AM

Return to search

Component/s:

SMTPServer

Affects Version/s:

2.3.0

Fix Version/s:

2.3.0

Time Tracking:

Not Specified

Resolution Date:

28/Jul/06 02:09 PM

Description

« Hide

A NPE is issued when receiving a "read receipt" from MS Outlook (not Outlook express nor Thunderbird), and <checkValidSenderDomain> is set to true and the sender IP address is not in <authorizedAddresses>:

27/07/06 17:17:00 ERROR smtpserver: Exception opening socket: null
java.lang.NullPointerException
at org.apache.james.smtpserver.MailCmdHandler.doMAIL(MailCmdHandler.java:210)
at org.apache.james.smtpserver.MailCmdHandler.onCommand(MailCmdHandler.java:83)
at org.apache.james.smtpserver.SMTPHandler.handleConnection(SMTPHandler.java:391)
at org.apache.james.util.connection.ServerConnection$ClientConnectionRunner.run(ServerConnection.java:422)
at org.apache.excalibur.thread.impl.ExecutableRunnable.execute(ExecutableRunnable.java:55)
at org.apache.excalibur.thread.impl.WorkerThread.run(WorkerThread.java:116)

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Vincenzo Gianferrari Pini added a comment - 27/Jul/06 03:37 PM

I don't know if this error was also in 2.2. In such case IMO we should consider it a blocker :-( , because after an upgrade from 2.2.0 to 2.3.0 the systems having <checkValidSenderDomain> set to true would lose messages.

Norman Maurer made changes - 27/Jul/06 03:44 PM

Field	Original Value	New Value
Assignee		Norman Maurer [ norman ]

Norman Maurer made changes - 27/Jul/06 04:22 PM

Priority

Major [ 3 ]

Blocker [ 1 ]

Repository	Revision	Date	User	Message
ASF	#426126	Thu Jul 27 16:29:19 UTC 2006	norman	Fix the Nullpointer on null sender if CheckValidSenderDomain is enabled. See ~~JAMES-580~~
				Files Changed
				MODIFY /james/server/trunk/src/java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java ADD /james/server/trunk/src/test/org/apache/james/smtpserver/ValidSenderDomainHandlerTest.java

Norman Maurer made changes - 27/Jul/06 04:29 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
Fix Version/s		2.3.0rc2 [ 12312012 ]

Repository	Revision	Date	User	Message
ASF	#426127	Thu Jul 27 16:31:03 UTC 2006	norman	Fix the Nullpointer on null sender if CheckValidSenderDomain is enabled. See ~~JAMES-580~~
				Files Changed
				MODIFY /james/server/branches/v2.3/src/java/org/apache/james/smtpserver/MailCmdHandler.java

[ Permlink | « Hide ]

Vincenzo Gianferrari Pini added a comment - 28/Jul/06 02:05 PM

The fix was ok for 3.0 in trunk, but not for 2.3.0.

Vincenzo Gianferrari Pini made changes - 28/Jul/06 02:05 PM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]
Assignee	Norman Maurer [ norman ]	Vincenzo Gianferrari Pini [ vincenzo ]

[ Permlink | « Hide ]

Vincenzo Gianferrari Pini added a comment - 28/Jul/06 02:09 PM

The fix now is checking senderAddress != null, instead of sender != null.

Vincenzo Gianferrari Pini made changes - 28/Jul/06 02:09 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ASF	#426542	Fri Jul 28 14:09:31 UTC 2006	vincenzo	The previous fix to ~~JAMES-580~~ was ok for 3.0 in trunk, but not for 2.3.0rc1.
				Files Changed
				MODIFY /james/server/branches/v2.3/src/java/org/apache/james/smtpserver/MailCmdHandler.java

[ Permlink | « Hide ]

Danny Angus added a comment - 21/Nov/07 08:31 AM

Closing issue fixed in released version.

Danny Angus made changes - 21/Nov/07 08:31 AM

Status

Resolved [ 5 ]

Closed [ 6 ]