NPE is issued when receiving a "read receipt" from MS Outlook, and <checkValidSenderDomain> is set to true

• Key: JAMES-580
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Vincenzo Gianferrari Pini
• Reporter: Vincenzo Gianferrari Pini
• Component/s: SMTPServer
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0

Description

A NPE is issued when receiving a "read receipt" from MS Outlook (not Outlook express nor Thunderbird), and <checkValidSenderDomain> is set to true and the sender IP address is not in <authorizedAddresses>:

27/07/06 17:17:00 ERROR smtpserver: Exception opening socket: null
java.lang.NullPointerException
at org.apache.james.smtpserver.MailCmdHandler.doMAIL(MailCmdHandler.java:210)
at org.apache.james.smtpserver.MailCmdHandler.onCommand(MailCmdHandler.java:83)
at org.apache.james.smtpserver.SMTPHandler.handleConnection(SMTPHandler.java:391)
at org.apache.james.util.connection.ServerConnection$ClientConnectionRunner.run(ServerConnection.java:422)
at org.apache.excalibur.thread.impl.ExecutableRunnable.execute(ExecutableRunnable.java:55)
at org.apache.excalibur.thread.impl.WorkerThread.run(WorkerThread.java:116)

Comments

[Vincenzo Gianferrari Pini]

I don't know if this error was also in 2.2. In such case IMO we should consider it a blocker :-( , because after an upgrade from 2.2.0 to 2.3.0 the systems having <checkValidSenderDomain> set to true would lose messages.

[Vincenzo Gianferrari Pini]

The fix was ok for 3.0 in trunk, but not for 2.3.0.

The fix now is checking senderAddress != null, instead of sender != null.

[Danny Angus]

Closing issue fixed in released version.