Rename AddHeader and AddHeaderHandler

• Key: JAMES-513
• Type: Task
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Norman Maurer
• Reporter: Norman Maurer
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0

Description

We should rename AddHeader and AddHeaderHandler to represent the function.
 

Comments

[Norman Maurer]

when working on junit test for AddHeaderHandler i notice that the
AddHeaderHandler use setHeader(String name, String value); . So it not
add a header, it set a header. This is not what i espected when i read
the Handlername.

So for me are 2 solutions:

1. Rename the AddHeaderHandler to SetHeaderHandler
2. use addHeader(String name, String value) instand of setHeader(String
name, String value)

i prefer the first. What the you think ?

[Norman Maurer]

Maybe we should rename the AddHeader to SetHeader and add new Method
which extend on this named AddHeader. This method should be marked as
deprected. Then we can later remove it.

Same to the handler.

What you guys think ?

[Norman Maurer]

To clarify my position:

+1 to deprecate the AddHeader and add a new Set*Header
   +0.6 to name it SetMimeHeader
   +0.4 to name it SetRfc822Header (most correct, but less intelligible
to non techies)
   +0.2 to name it SetHeader

Furthermore

+1 to do that in the 2.3 branch and remove AddHeader from the trunk

Stefano

[Norman Maurer]

Should we merge it in the branch so we can remove the old classes in 2.4/3.0 ?

[Danny Angus]

Closing issue fixed in released version.