Set the last modified attribute of files downloaded from repositories

• Key: IVY-823
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Maarten Coene
• Reporter: Claudio Miranda
• Component/s: Core
• Fix Version/s: 2.0-RC1

Description

A small modification, to allow the downloaded resource to have the same date timestamp as the file in remote repo.

At org.apache.ivy.util.url.BasicURLHandler.download(URL src, File dest, CopyProgressListener l)
Add

dest.setLastModified(srcConn.getLastModified());

However this modification is intended to be configurable, see below

Quoting Gilles Scokart from the discussion thread
http://www.nabble.com/-Ivy--How-to-add-a-new-option-to-ivy-settings-td17526130.html

> I think it should better be a parameter of the retrieve task, or maybe
> an attribute of the resolver in the settings file.
> preservelastmodified sounds a good name (like the ant copy task).
>
> Note that if you put it in the resolver settings, that should maybe
> also impact the publish and the install task.
> If you put it in both the settings and the task, then the task should
> have the priority.

Index: src/java/org/apache/ivy/util/url/BasicURLHandler.java
===================================================================
— src/java/org/apache/ivy/util/url/BasicURLHandler.java (revision 661197)
+++ src/java/org/apache/ivy/util/url/BasicURLHandler.java (working copy)
@@ -131,6 +131,10 @@
"Downloaded file size doesn't match expected Content Length for " + src
+ ". Please retry.");
}
+ boolean remoteTimestamp = true;
+ if (remoteTimestamp) { + dest.setLastModified(srcConn.getLastModified()); + }
} finally {
disconnect(srcConn);