Issue Details (XML | Word | Printable)

Key: IVY-325
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Xavier Hanin
Reporter: Xavier Hanin
Votes: 1
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
Ivy

declare source and javadoc artifacts in maven2 modules

Created: 11/Oct/06 04:08 PM   Updated: 28/Jan/09 09:33 AM  Due: 17/Nov/06
Return to search
Component/s: Maven Compatibility
Affects Version/s: 1.4
Fix Version/s: 2.0-RC1

Time Tracking:
Not Specified

Issue Links:
Duplicate
 
Reference

Resolution Date: 06/Jun/08 10:12 AM


 Description  « Hide
Maven2 modules created when Ivy parses poms do not declare any source or javadoc artifact, while they sometimes offer one on ibiblio. Declaring such artifact could ease the integration of maven2 modules with source and javadoc attachments.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Xavier Hanin made changes - 29/Feb/08 11:45 AM
Field Original Value New Value
Assignee Xavier Hanin [ xavier ]
Maarten Coene made changes - 31/Mar/08 07:50 PM
Link This issue is duplicated by IVY-761 [ IVY-761 ]
Nicolas Lalevée made changes - 31/Mar/08 09:19 PM
Component/s Maven Compatibility [ 12312101 ]
Howard M. Lewis Ship added a comment - 04/Jun/08 03:50 PM
I think this falls under a general heading of "lets make it easier to download sources along with jars." Half the point of working in open source is so that I can have access to the source code. I don't miss the days of stepping through Weblogic code ...

Xavier Hanin made changes - 06/Jun/08 09:22 AM
Assignee Xavier Hanin [ xavier ]
Repository Revision Date User Message
ASF #663878 Fri Jun 06 10:07:18 UTC 2008 xavier IMPROVEMENT: declare source and javadoc artifacts in maven2 modules (IVY-325)
Files Changed
ADD /ant/ivy/core/trunk/test/repositories/m2/org/apache/test-sources/1.0/test-sources-1.0-javadoc.jar
ADD /ant/ivy/core/trunk/test/repositories/m2/org/apache/test-sources2/1.0
MODIFY /ant/ivy/core/trunk/CHANGES.txt
ADD /ant/ivy/core/trunk/test/java/org/apache/ivy/core/resolve/ivy-m2-with-sources-and-javadoc-auto.xml
ADD /ant/ivy/core/trunk/test/repositories/m2/org/apache/test-sources2/1.0/test-sources2-1.0-sources.jar
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java
ADD /ant/ivy/core/trunk/test/repositories/m2/org/apache/test-sources2/1.0/test-sources2-1.0.jar
MODIFY /ant/ivy/core/trunk/test/java/org/apache/ivy/core/resolve/ResolveTest.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
ADD /ant/ivy/core/trunk/test/repositories/m2/org/apache/test-sources2
ADD /ant/ivy/core/trunk/test/repositories/m2/org/apache/test-sources2/1.0/test-sources2-1.0.pom

Xavier Hanin added a comment - 06/Jun/08 10:12 AM
I've just implemented this, now m2 modules expose both a "sources" and "javadoc" configuration, containing the corresponding artifact if it exists.

I agree that this is not enough to work with sources and javadocs easily. Indeed, you can easily get sources and/or javadoc of one dependency, but it doesn't work transitively. To get sources and/or javadoc only of artifacts requested by the configurations actually needed, some kind of flag would be better.


Xavier Hanin made changes - 06/Jun/08 10:12 AM
Fix Version/s 2.0-RC1 [ 12313012 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Repository Revision Date User Message
ASF #689804 Thu Aug 28 12:48:19 UTC 2008 xavier improve source and javadoc artifacts detection in poms, to avoid considering the main artifact as being also javadoc and source artifact, when the pattern used for artifacts doesn't use neither type nor classifier token (related to IVY-325 and IVYDE-117)
Files Changed
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/AbstractResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IvyRepResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/CacheResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/ChainResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/DualResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/DependencyResolver.java
MODIFY /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/BasicResolver.java

Simon Brunning made changes - 06/Oct/08 04:31 PM
Link This issue is duplicated by IVY-936 [ IVY-936 ]
Jyri Kytömäki added a comment - 05/Nov/08 05:49 PM
Thanks for this.
Support for fetching sources also transitively would be really good.
We would not like to add all dependencies for projects in top level just because we need also their sources.

Nicolas Lalevée made changes - 10/Nov/08 11:53 AM
Link This issue is related to IVYDE-128 [ IVYDE-128 ]
Brian Matzon added a comment - 27/Jan/09 10:27 PM
This now breaks a lot of applications that do not have [type] in the artifact pattern as source and javadoc jars (with the same name) is being downloaded, resulting in an error since they try to overwrite each other.

should install have an exclude section to avoid getting these?


Xavier Hanin added a comment - 28/Jan/09 09:00 AM
Maybe we should have a flag to disable this feature for better backward compatibility. Could you open a JIRA?

Brian Matzon made changes - 28/Jan/09 09:31 AM
Link This issue relates to IVY-1021 [ IVY-1021 ]
Brian Matzon added a comment - 28/Jan/09 09:33 AM
I have created a new issue: IVY-1021
Hope to have this solved quickly!