[CAUSEWAY-909] BookmarksPagesPanel often cannot detect the current/active model

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Abandoned
• Affects Version/s: viewer-wicket-1.6.0
• Component/s: Viewer Wicket
• Assignee: Unassigned
• Reporter: Martin Tzvetanov Grigorov
• Created: 28/Sep/14 13:02
• Updated: 29/Apr/22 07:51
• Resolved: 29/Apr/22 07:51

Description

See also ISIS-842.

 

~~~

There is a logic [1] at BookmarkedPagesPanel.java that tries to detect whether an item in the bookmarks sliding menu is the currently viewed/edited item and sets CSS class "currentBookmark".

Most of the time bookmarkedPagesModel.isCurrent(pageParameters) doesn't work. It uses Objects.equal(current, pageParameters) and often those have similar oid but additional parameters make the check failing.

1. https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.java#L167