[IMPALA-7331] Add Char codegen support to helpers

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 3.3.0
• Component/s: Backend
• Labels: codegen
• Target Version: Product Backlog
• Epic Color: ghx-label-3
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 20/Jul/18 18:48
• Updated: 15/May/19 22:37
• Resolved: 15/May/19 22:37

Description

There are a lot of generic helpers with missing TYPE_CHAR support. We need to add char to those. The tuple layout is identical to TYPE_FIXED_UDA_INTERMEDIATE and the UDF StringVal type is used the same as TYPE_STRING, so mostly this requires using those code paths for CHAR and doing appropriate testing to ensure that it works (the random query generator may help here!).

E.g.
https://github.com/apache/impala/blob/4a39e7c/be/src/codegen/codegen-anyval.cc#L58
https://github.com/apache/impala/blob/4a39e7c29f7b910c9ae0d622b355e9362c17aaec/be/src/runtime/descriptors.cc#L712