Issue Details (XML | Word | Printable)

Key: HTTPCORE-14
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Oleg Kalnichevski
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
HttpComponents HttpCore

Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Created: 27/Sep/06 06:30 PM   Updated: 11/Nov/07 07:22 PM
Return to search
Component/s: HttpCore
Affects Version/s: None
Fix Version/s: 4.0-alpha3

Time Tracking:
Not Specified

File Attachments:
  File Name Date Attached Attached By Size
Text File Licensed for inclusion in ASF works 20060929-httphost.patch 2006-09-29 12:03 PM Oleg Kalnichevski 21 kB

Resolution Date: 29/Sep/06 08:24 PM


 Description  « Hide
SocketFactory interface in HttpCore implies a blocking process of opening a new socket. Moreover, there is no way to interrupt the process of opening a connection due to limitations of Java 1.3 API.

I suggest the SocketFactory and SecureSocketFactory interfaces and the Scheme class dependent on those interfaces be moved to HttpConn and the HttpHost class be decoupled from Scheme.

(This is going to be the last controversial bit I wanted to propose and once this issue is resolved I can safely declare I am done with HttpCore)

Oleg

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
Oleg Kalnichevski added a comment - 27/Sep/06 06:31 PM
Please review and let me know what you think

Oleg

Oleg Kalnichevski made changes - 27/Sep/06 06:31 PM
Field Original Value New Value
Attachment 20060927-httphost.patch [ 12341819 ]
[ Permlink | « Hide ]
Roland Weber added a comment - 28/Sep/06 05:22 PM
Hi Oleg,

I think the scheme should remain in HttpHost as a String. Maybe with automatic lowercase conversion.
The getter method could be called getSchemeName instead of getScheme, to avoid confusion.
Otherwise, I'm fine with this change.

(I have one more idea for HttpCore, but it's rather a side issue and doesn't have to go into the next alpha.)

cheers,
  Roland

Oleg Kalnichevski made changes - 29/Sep/06 12:02 PM
Attachment 20060927-httphost.patch [ 12341819 ]
[ Permlink | « Hide ]
Oleg Kalnichevski added a comment - 29/Sep/06 12:03 PM
Roland, how about this?

Oleg

Oleg Kalnichevski made changes - 29/Sep/06 12:03 PM
Attachment 20060929-httphost.patch [ 12341966 ]
[ Permlink | « Hide ]
Roland Weber added a comment - 29/Sep/06 05:53 PM
Yes, that's it.

cheers,
  Roland

Repository Revision Date User Message
ASF #451396 Fri Sep 29 19:27:41 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* HttpHost is no longer coupled with the Scheme class
* ProxyHost removed
Files Changed
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ProxyHost.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/src/contrib/org/apache/http/contrib/spring/http-beans.xml
MODIFY /jakarta/httpcomponents/httpcore/trunk/src/contrib/org/apache/http/contrib/benchmark/HttpBenchmark.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/params/HttpProtocolParams.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/RequestTargetHost.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/HttpHost.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/protocol/TestStandardInterceptors.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/src/contrib/org/apache/http/contrib/spring/SpringHttpDemo.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/src/contrib/org/apache/http/contrib/benchmark/BenchmarkWorker.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/TestHttpHost.java

Repository Revision Date User Message
ASF #451398 Fri Sep 29 19:28:52 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* HttpHost is no longer coupled with the Scheme class
* ProxyHost removed
Files Changed
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/java/org/apache/http/async/impl/SimpleHttpAsyncClientConnection.java

Repository Revision Date User Message
ASF #451405 Fri Sep 29 19:54:01 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/Scheme.java
ADD /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/Scheme.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/Scheme.java)

Repository Revision Date User Message
ASF #451407 Fri Sep 29 19:57:43 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
ADD /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/SocketFactory.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/io/SocketFactory.java)
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/io/SocketFactory.java

Repository Revision Date User Message
ASF #451408 Fri Sep 29 19:58:24 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
ADD /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/SecureSocketFactory.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/io/SecureSocketFactory.java)
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/io/SecureSocketFactory.java

Repository Revision Date User Message
ASF #451410 Fri Sep 29 19:59:13 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
ADD /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/PlainSocketFactory.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/PlainSocketFactory.java)
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/PlainSocketFactory.java

Repository Revision Date User Message
ASF #451412 Fri Sep 29 20:06:44 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/ssl/SSLSocketFactory.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/PlainSocketFactory.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/SecureSocketFactory.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/Scheme.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/SocketFactory.java
ADD /jakarta/httpcomponents/httpclient/trunk/src/test/org/apache/http/conn

Repository Revision Date User Message
ASF #451413 Fri Sep 29 20:08:44 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
ADD /jakarta/httpcomponents/httpclient/trunk/src/test/org/apache/http/conn/TestScheme.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/TestScheme.java)
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/TestScheme.java

Repository Revision Date User Message
ASF #451415 Fri Sep 29 20:11:15 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
ADD /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/ConnectTimeoutException.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ConnectTimeoutException.java)
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ConnectTimeoutException.java

Repository Revision Date User Message
ASF #451416 Fri Sep 29 20:12:04 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/TestAll.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/TestHttpExceptions.java
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/SSLSocketFactory.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/examples/org/apache/http/examples/ElementalHttpGet.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/examples/org/apache/http/examples/ElementalHttpPost.java

Repository Revision Date User Message
ASF #451418 Fri Sep 29 20:13:41 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/examples/org/apache/http/examples/ElementalAsyncGet.java
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/examples/org/apache/http/examples/NotifiedAsyncGet.java
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/contrib/org/apache/http/async/contrib/routing/RoutingAsyncGet.java

Repository Revision Date User Message
ASF #451422 Fri Sep 29 20:15:32 UTC 2006 olegk [HTTPCORE-14] Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

Changelog:
----------
* Moved Scheme, SocketFactory, SecureSocketFactory and related classes to HttpConn
Files Changed
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/ssl/SSLSocketFactory.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/test/org/apache/http/conn/TestScheme.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/ConnectTimeoutException.java
MODIFY /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/conn/SocketFactory.java

[ Permlink | « Hide ]
Oleg Kalnichevski added a comment - 29/Sep/06 08:24 PM
Patch checked in. Files moved.

Oleg

Oleg Kalnichevski made changes - 29/Sep/06 08:24 PM
Fix Version/s 4.0-alpha3 [ 12311940 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Roland Weber made changes - 11/Nov/07 07:22 PM
Status Resolved [ 5 ] Closed [ 6 ]

Powered by a free Atlassian JIRA open source license for Apache Software Foundation. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators