Consider decoupling HttpHost and Scheme and moving Scheme, SocketFactory and SecureSocketFactory to HttpConn

• Key: HTTPCORE-14
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Oleg Kalnichevski
• Component/s: HttpCore
• Fix Version/s: 4.0-alpha3

Description

SocketFactory interface in HttpCore implies a blocking process of opening a new socket. Moreover, there is no way to interrupt the process of opening a connection due to limitations of Java 1.3 API.

I suggest the SocketFactory and SecureSocketFactory interfaces and the Scheme class dependent on those interfaces be moved to HttpConn and the HttpHost class be decoupled from Scheme.

(This is going to be the last controversial bit I wanted to propose and once this issue is resolved I can safely declare I am done with HttpCore)

Oleg

Comments

[Oleg Kalnichevski]

Please review and let me know what you think

Oleg

[Roland Weber]

Hi Oleg,

I think the scheme should remain in HttpHost as a String. Maybe with automatic lowercase conversion.
The getter method could be called getSchemeName instead of getScheme, to avoid confusion.
Otherwise, I'm fine with this change.

(I have one more idea for HttpCore, but it's rather a side issue and doesn't have to go into the next alpha.)

cheers,
  Roland

Roland, how about this?

Oleg

[Roland Weber]

Yes, that's it.

cheers,
  Roland

[Oleg Kalnichevski]

Patch checked in. Files moved.

Oleg