Issue Details (XML | Word | Printable)

Key: HTTPCORE-13
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Roland Weber
Reporter: Roland Weber
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
HttpComponents HttpCore

AbstractHttpProcessor is not really abstract

Created: 25/Sep/06 01:16 PM   Updated: 02/Oct/06 06:59 AM
Return to search
Component/s: HttpCore
Affects Version/s: 4.0-alpha3
Fix Version/s: 4.0-alpha3

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works 2k6-09-25-core-proc-1.txt 2006-09-25 01:22 PM Roland Weber 22 kB

Resolution Date: 02/Oct/06 06:59 AM


 Description  « Hide
AbstractHttpProcessor is declared abstract though it does not have any abstract method. This artificially restricts use of the base class functionality to subclassing and prohibits use by reference. That is one of the reasons why HttpAsync has an ugly AsyncHttpProcessor class.

Patch follows.


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #449756 Mon Sep 25 17:48:15 UTC 2006 rolandw HTTPCORE-13, take 1 plus JavaDoc fixes
Files Changed
ADD /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/protocol
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/package.html
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpService.java
ADD /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpProcessor.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java
DEL /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/AbstractHttpProcessor.java
ADD /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/protocol/DefaultHttpProcessor.java (from /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/AbstractHttpProcessor.java)
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/examples/org/apache/http/examples/ElementalHttpServer.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/examples/org/apache/http/examples/ElementalHttpGet.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/src/contrib/org/apache/http/contrib/benchmark/BenchmarkWorker.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/examples/org/apache/http/examples/ElementalHttpPost.java

Repository Revision Date User Message
ASF #449761 Mon Sep 25 17:56:48 UTC 2006 rolandw minimal changes to adapt to HTTPCORE-13, take 1
Files Changed
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/examples/org/apache/http/examples/ElementalAsyncGet.java
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/java/org/apache/http/async/AsyncHttpProcessor.java
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/examples/org/apache/http/examples/NotifiedAsyncGet.java
MODIFY /jakarta/httpcomponents/httpasync/trunk/src/contrib/org/apache/http/async/contrib/routing/RoutingAsyncGet.java

Repository Revision Date User Message
ASF #450974 Thu Sep 28 19:12:49 UTC 2006 olegk [HTTPCORE-13] AbstractHttpProcessor is not really abstract

Changelog:
----------
* Aligned the method names of HttpProcessor interface with with those in Http{Request|Response}Interceptor.
Files Changed
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpService.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpProcessor.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java

Repository Revision Date User Message
ASF #450978 Thu Sep 28 19:26:50 UTC 2006 olegk [HTTPCORE-13] AbstractHttpProcessor is not really abstract

Changelog:
----------
* HttpService does no longer directly import impl classes
Files Changed
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/HttpService.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-nio/src/examples/org/apache/http/nio/examples/AsyncHttpServer.java
MODIFY /jakarta/httpcomponents/httpcore/trunk/module-main/src/examples/org/apache/http/examples/ElementalHttpServer.java