[HIVE-9151] Checking s against null in TezJobMonitor#getNameWithProgress() should be done earlier

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.1.0, 1.2.0
• Fix Version/s: 1.2.0
• Assignee: Prasanth Jayachandran
• Reporter: Ted Yu
• Created: 17/Dec/14 22:25
• Updated: 18/May/15 19:53
• Resolved: 03/Feb/15 18:15

Description

    int spaceRemaining = COLUMN_1_WIDTH - s.length() - 1;
    String trimmedVName = s;

    // if the vertex name is longer than column 1 width, trim it down
    // "Tez Merge File Work" will become "Tez Merge File.."
    if (s != null && s.length() > COLUMN_1_WIDTH) {

s is dereferenced first, rendering the null check ineffective.