[HIVE-8806] Potential null dereference in Metrics#incrementCounter()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Later
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 10/Nov/14 19:32
• Updated: 01/Feb/15 02:26
• Resolved: 01/Feb/15 02:26

Description

      if (!metrics.hasKey(name)) {
        value = Long.valueOf(increment);
        set(name, value);
      } else {
        value = ((Long)get(name)) + increment;
        set(name, value);
      }

In the else block, if get(name) returns null, unboxing null object would lead to exception.