[HIVE-6594] UnsignedInt128 addition does not increase internal int array count resulting in corrupted values during serialization

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.13.0, 0.14.0
• Component/s: Query Processor
• Assignee: Remus Rusanu
• Reporter: Remus Rusanu
• Created: 08/Mar/14 13:22
• Updated: 13/Nov/14 19:42
• Resolved: 11/Mar/14 12:51

Description

Discovered this while investigating why my fix for HIVE-6222 produced diffs. I discovered that Decimal128.addDestructive does not adjust the internal count when an the number of relevant ints increases. Since this count is used in the fast HiveDecimalWriter conversion code, the results are off.

The root cause is UnsignedDecimal128.differenceInternal does not do an updateCount() on the result.