[HIVE-5641] BeeLineOpts ignores Throwable

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Assignee: Brock Noland
• Reporter: Brock Noland
• Created: 24/Oct/13 15:57
• Updated: 06/Dec/13 16:52
• Resolved: 06/Dec/13 16:52

Description

BeelineOpts has the following code:

    } catch (Throwable t) {
       return -1;
     }

which is bad. I believe it is there because the code called maybe buggy and throw such things as ArrayIndex or NoSuchElement etc.

I propose we:

1) catch exception, not throwable. Usage should remain the same without having a giant black hole
2) that we log the exception so we can figure out what is wrong with the underlying code