[HIVE-5098] Fix metastore for SQL Server

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Metastore, Windows
• Hadoop Flags: Reviewed
• Assignee: Daniel Dai
• Reporter: Daniel Dai
• Created: 14/Aug/13 23:52
• Updated: 10/Dec/13 19:14
• Resolved: 10/Dec/13 19:13

Description

We found one problem in testing SQL Server metastore. In Hive code, we use substring function with single parameter in datanucleus query (Expressiontree.java):

if (partitionColumnIndex == (partitionColumnCount - 1)) {
        valString = "partitionName.substring(partitionName.indexOf(\"" + keyEqual + "\")+" + keyEqualLength + ")";
      }
      else {
        valString = "partitionName.substring(partitionName.indexOf(\"" + keyEqual + "\")+" + keyEqualLength + ").substring(0, partitionName.substring(partitionName.indexOf(\"" + keyEqual + "\")+" + keyEqualLength + ").indexOf(\"/\"))";
      }

SQL server does not support single parameter substring and datanucleus does not fill the gap.

In the attached patch:
1. creates a new jar hive-datanucleusplugin.jar in $HIVE_HOME/lib
2. hive-datanucleusplugin.jar is a datanucleus plugin (include plugin.xml, MANIFEST.MF)
3. The plugin write a specific version of "substring" implementation for sqlserver (which avoid using single param SUBSTRING, which is not supported in SQLSever)
4. The plugin code only kicks in when the rmdb is sqlserver