[HIVE-4533] vectorized NotCol operation does not handle short-circuit evaluation for NULL propagation correctly

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: Jitendra Nath Pandey
• Reporter: Eric N. Hanson
• Created: 10/May/13 00:02
• Updated: 14/May/13 21:27
• Resolved: 14/May/13 21:27

Description

See file NotCol.java in org.apache.hadoop.hive.ql.exec.vector.expressions.

This code does not look at the selection vector so it may waste time propagating nulls if the batch has already been filtered.

A more serious problem is that it only copies over n entries. So if a filter has been applied, nulls my not be copied over when they should.

// handle NULLs
if (inputColVector.noNulls)

{ outV.noNulls = true; }

else {
outV.noNulls = false;
if (inputColVector.isRepeating)

{ outV.isNull[0] = inputColVector.isNull[0]; }

else

{ System.arraycopy(inputColVector.isNull, 0, outV.isNull, 0, n); }

}

Issue Links

• is part of: HIVE-4534 IsNotNull and NotCol incorrectly handle nulls.