Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4067

Followup to HIVE-701: reduce ambiguity in grammar

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.11.0
    • 0.11.0
    • Query Processor
    • None

    Description

      After HIVE-701 the grammar has become much more ambiguous, and the compilation generates a large number of warnings. Making FROM, DISTINCT, PRESERVE, COLUMN, ALL, AND, OR, and NOT reserved keywords again reduces the number of warnings to 134, up from the original 81 warnings but down from the 565 after HIVE-701. Most of the remaining ambiguity is trivial, an example being "KW_ELEM_TYPE | KW_KEY_TYPE | KW_VALUE_TYPE | identifier", and they are all correctly handled by ANTLR.

      Attachments

        1. HIVE-4067.HIVE-4067.HIVE-4067.HIVE-4067.D8883.2.patch
          16 kB
          Phabricator
        2. HIVE-4067.D8883.1.patch
          15 kB
          Phabricator

        Issue Links

          relates to

          Task - A task that needs to be done. HIVE-6617 Reduce ambiguity in grammar

          • Major - Major loss of function.
          • Closed

          Activity

            People

              sxyuan Samuel Yuan
              sxyuan Samuel Yuan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: