[HIVE-19263] Improve ugly exception handling in HiveMetaStore

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Standalone Metastore
• Assignee: Igor Kryvenko
• Reporter: Igor Kryvenko
• Created: 21/Apr/18 17:07
• Updated: 17/Nov/22 08:55
• Resolved: 24/Apr/18 02:19

Description

In HiveMetaStore class we have a lot of ugly exception handling code using which use instanceof

 catch (Exception e) {
        ex = e;
        if (e instanceof MetaException) {
          throw (MetaException) e;
        } else if (e instanceof InvalidObjectException) {
          throw (InvalidObjectException) e;
        } else if (e instanceof AlreadyExistsException) {
          throw (AlreadyExistsException) e;
        } else {
          throw newMetaException(e);
        }