Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-18880

Change Log to Debug in CombineHiveInputFormat

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.0.0
    • 4.0.0-alpha-1
    • HiveServer2

    Description

      https://github.com/apache/hive/blob/1e74aca8d09ea2ef636311d2168b4d34198f7194/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java#L467

        private InputSplit[] getCombineSplits(JobConf job, int numSplits,
            Map<Path, PartitionDesc> pathToPartitionInfo) {
      ...
        LOG.info("number of splits " + result.size());
      ...
      }
      

      https://github.com/apache/hive/blob/1e74aca8d09ea2ef636311d2168b4d34198f7194/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java#L587

      public InputSplit[] getSplits(JobConf job, int numSplits) throws IOException {
      ...
        LOG.info("Number of all splits " + result.size());
      ...
      }
      
      1. Capitalize "N"umber in the first logging to be consistent across all logging statements
      2. Change the first logging message to be debug level seeing as it's in a private method.
        It's an implementation logging and the entire total (most useful for a client) is captured in info level at the end of the public method.

      Attachments

        1. HIVE-18880.patch
          0.7 kB
          Antal Sinkovits
        2. HIVE-18880.2.patch
          0.7 kB
          Antal Sinkovits

        Activity

          People

            asinkovits Antal Sinkovits
            belugabehr David Mollitor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: