[HIVE-18865] Check filesystem calls return value (codescan)

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Thejas Nair
• Created: 05/Mar/18 20:09
• Updated: 05/Mar/18 20:28

Description

There are a few places where return value of certain filesystem operations are not being checked.
Hive should at the very least log these failures.

1. Overview : The method saveDir() in BeeLineOpts.java ignores the value returned by mkdirs() on line 174, which could cause the program to overlook unexpected states and conditions.
In the file BeeLineOpts.java similar issues were on line numbers 174
2. Overview : The method compile() in CompileProcessor.java ignores the value returned by mkdir() on line 226, which could cause the program to overlook unexpected states and conditions.
In the file CompileProcessor.java similar issues were on line numbers 234, 226
3. Overview : The method deleteTmpFile() in FileUtils.java ignores the value returned by delete() on line 939, which could cause the program to overlook unexpected states and conditions.
In the file FileUtils.java similar issues were on line numbers 939