[HIVE-18110] OrcInputFormat.combineOrCreateETLStrategy() doesn't combine if there are deltas

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.0.0
• Component/s: Transactions
• Target Version/s: 3.0.0
• Assignee: Unassigned
• Reporter: Eugene Koifman
• Created: 21/Nov/17 01:40
• Updated: 21/Nov/17 01:56

Description

this method has

    if (!deltas.isEmpty() || combinedCtx == null) {
      //why is this checking for deltas.isEmpty() - is this Acid 1.0 remnant?
      return new ETLSplitStrategy(
          context, fs, dir, files, readerTypes, isOriginal, deltas, covered, ugi,
          allowSyntheticFileIds, isDefaultFs);
    } else

what is the purpose of checking deltas? (here with Acid 2.0 deltas is delete deltas)
Is this some remnant of Acid 1.0?

Also see TestInputOutputFormat.testEtlCombinedStrategy

Issue Links

• is related to: HIVE-17089 make acid 2.0 the default