[HIVE-17371] Move tokenstores to metastore module

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: Standalone Metastore
• Assignee: Vihang Karajgaonkar
• Reporter: Vihang Karajgaonkar
• Created: 22/Aug/17 15:26
• Updated: 01/Oct/19 22:07
• Resolved: 17/Oct/17 02:44

Description

The getTokenStore method will not work for the DBTokenStore and ZKTokenStore since they implement org.apache.hadoop.hive.thrift.DelegationTokenStore instead of org.apache.hadoop.hive.metastore.security.DelegationTokenStore

private DelegationTokenStore getTokenStore(Configuration conf) throws IOException {
    String tokenStoreClassName =
        MetastoreConf.getVar(conf, MetastoreConf.ConfVars.DELEGATION_TOKEN_STORE_CLS, "");
    // The second half of this if is to catch cases where users are passing in a HiveConf for
    // configuration.  It will have set the default value of
    // "hive.cluster.delegation.token.store .class" to
    // "org.apache.hadoop.hive.thrift.MemoryTokenStore" as part of its construction.  But this is
    // the hive-shims version of the memory store.  We want to convert this to our default value.
    if (StringUtils.isBlank(tokenStoreClassName) ||
        "org.apache.hadoop.hive.thrift.MemoryTokenStore".equals(tokenStoreClassName)) {
      return new MemoryTokenStore();
    }
    try {
      Class<? extends DelegationTokenStore> storeClass =
          Class.forName(tokenStoreClassName).asSubclass(DelegationTokenStore.class);
      return ReflectionUtils.newInstance(storeClass, conf);
    } catch (ClassNotFoundException e) {
      throw new IOException("Error initializing delegation token store: " + tokenStoreClassName, e);
    }
  }

Issue Links

• links to: Review Board