[HIVE-17329] ensure acid side file is not overwritten

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Done
• Fix Version/s: 3.0.0
• Component/s: Transactions
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 15/Aug/17 22:42
• Updated: 22/May/18 23:59
• Resolved: 25/Aug/17 17:34

Description

OrcRecordUpdater() has

      flushLengths = fs.create(OrcAcidUtils.getSideFile(this.path), true, 8,
          options.getReporter());

this should be the only place where the side file is created but to be safe we should set "overwrite" parameter to false. If this file already exists that means there are 2 OrcRecordUpdates trying to write the same (primary) file - never ok.