Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-17117

Metalisteners are not notified when threadlocal metaconf is cleanup

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0
    • Metastore
    • None
    • Tested on master branch (Applicable for downlevel versions as well)

    Description

      Meta listeners are not notified of meta-conf cleanup. This could potentially leave stale values on listeners objects. For e.g.

      Request1
      a. HS2 -> HMS : HMSHandler#setMetaConf
      MetaListeners are notified of the ConfigChangeEvent.
      b. HS2 -> HMS : HMSHandler#shutdown / HiveMetaStore#deleteContext (if shutdown is not invoked)
      MetaConf is cleaned up in HiveMetaStore#cleanupRawStore, but meta listeners are not notified

      Request 2
      3. HS2->HMS : AlterPartition
      MetaListeners are notified of AlterPartitionEvent. If any listener has taken dependency on the meta conf value, it will still be having stale value from Request1 and would potentially be having issues.

      The correct behavior should be to notify meta listeners on cleanup as well.

      Attachments

        1. HIVE-17117.patch
          10 kB
          Prashant Golash
        2. HIVE-17117.1.patch
          11 kB
          Prashant Golash

        Activity

          People

            pgolash Prashant Golash
            pgolash Prashant Golash
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: