[HIVE-16688] Make sure Alter Table to set transaction=true acquires X lock

• Type: Sub-task
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 3.0.0
• Component/s: Transactions
• Target Version/s: 3.0.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 17/May/17 00:23
• Updated: 01/Oct/19 22:06
• Resolved: 16/Oct/17 23:11

Description

suppose we have non-acid table with some data
An insert op starts (long running) (with hive.txn.strict.locking.mode=false this takes shared lock)
An alter table runs to add (transactional=true)
An update is run which will read the list of "original" files and assign IDs on the fly which are written to a delta file.
The long running insert completes.
Another update is run which now sees a different set of "original" files and will (most likely) assign different IDs.

Need to make sure to mutex this

To clarify: The X lock is acquired for "An alter table runs to add (transactional=true)"

Issue Links

• is related to: HIVE-16722 Converting bucketed non-acid table to acid should perform validation