[HIVE-16612] PerfLogger is configurable, but not extensible

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Component/s: Query Planning, Query Processor
• Assignee: Remus Rusanu
• Reporter: Remus Rusanu
• Created: 09/May/17 05:50
• Updated: 04/Apr/18 22:37

Description

          result = (PerfLogger) ReflectionUtils.newInstance(conf.getClassByName(
            conf.getVar(HiveConf.ConfVars.HIVE_PERF_LOGGER)), conf);

The PerfLogger instance is configurable via hive.exec.perf.logger (HIVE-11891) but the requirement to extend from PerfLogger cannot be met since HIVE-11149 as the ctor is private. Also useful methods in PerfLogger are also private. I tried to extend PerfLogger for my needs and realized that, as is, the configurability is not usable. At the very least the PerfLogger should make all private members protected, better the requirement should be an interface not a class.