[HIVE-15671] RPCServer.registerClient() erroneously uses server/client handshake timeout for connection timeout

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 2.3.0
• Component/s: Spark
• Assignee: Xuefu Zhang
• Reporter: Xuefu Zhang
• Created: 20/Jan/17 02:49
• Updated: 21/Jul/17 18:36
• Resolved: 13/Feb/17 19:08

Description

  /**
   * Tells the RPC server to expect a connection from a new client.
   * ...
   */
  public Future<Rpc> registerClient(final String clientId, String secret,
      RpcDispatcher serverDispatcher) {
    return registerClient(clientId, secret, serverDispatcher, config.getServerConnectTimeoutMs());
  }

config.getServerConnectTimeoutMs() returns value for hive.spark.client.server.connect.timeout, which is meant for timeout for handshake between Hive client and remote Spark driver. Instead, the timeout should be hive.spark.client.connect.timeout, which is for timeout for remote Spark driver in connecting back to Hive client.

Issue Links

• relates to: HIVE-16071 HoS RPCServer misuses the timeout in its RPC handshake
• relates to: HIVE-15893 Followup on HIVE-15671