[HIVE-15145] Alter partition and fs renameDir should happen in same transaction

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Mohit Sabharwal
• Reporter: Mohit Sabharwal
• Created: 07/Nov/16 23:42
• Updated: 07/Nov/16 23:42

Description

In HiveAlterTable#alterPartition, the rename partition logic is as follows:

• open txn
• db.alterPartition(old, new)
• commit txn
• fs.mkdirs
• if mkdirs fails
  • open txn
  • db.alterPartition(new, old)
  • commit txn

Instead, both db.alterPartition(old, new) and fs.mkdirs can be moved under a single transaction.

Currently, if the second db.alterPartition(new, old) fails, we have a partition metadata committed without corresponding partition directory.